Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: close sockets in SQL tests #35772

Merged
merged 1 commit into from
Aug 17, 2020
Merged

CI: close sockets in SQL tests #35772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas/tests/io/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,8 @@ def _get_all_tables(self):
return table_list

def _close_conn(self):
pass
# https://docs.sqlalchemy.org/en/13/core/connections.html#engine-disposal
self.conn.dispose()


class PandasSQLTest:
Expand Down Expand Up @@ -1242,7 +1243,7 @@ class _TestSQLAlchemy(SQLAlchemyMixIn, PandasSQLTest):
def setup_class(cls):
cls.setup_import()
cls.setup_driver()
conn = cls.connect()
conn = cls.conn = cls.connect()
conn.connect()

def load_test_data_and_sql(self):
Expand Down