Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: close sockets in SQL tests #35772

Merged
merged 1 commit into from
Aug 17, 2020
Merged

CI: close sockets in SQL tests #35772

merged 1 commit into from
Aug 17, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Aug 17, 2020 •
edited by jreback
Loading

closes #35660
closes #29514

Broken off from #35711

@alimcmaster1
Copy link
Member

Nice this one has been hanging round for awhile. Think it also closes: #29514

@alimcmaster1 alimcmaster1 added CI Continuous Integration Testing pandas testing functions or related to the test suite labels Aug 17, 2020
@jreback jreback added this to the 1.2 milestone Aug 17, 2020
@jreback jreback merged commit 13940c7 into pandas-dev:master Aug 17, 2020
@jreback
Copy link
Contributor

jreback commented Aug 17, 2020

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ci-files-sql branch August 17, 2020 21:56
@simonjayhawkins
Copy link
Member

can the @pytest.mark.xfail(reason="ResourceWarning #35660", strict=False) added in #35672 be removed now?

@jbrockmendel
Copy link
Member Author

can the @pytest.mark.xfail(reason="ResourceWarning #35660", strict=False) added in #35672 be removed now?

I expect so, yes

@simonjayhawkins simonjayhawkins mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

BUG/CI: unreliable tests in io\parser\test_common.py Flakey Test in CI - Unclosed File Handle
4 participants
@jbrockmendel @alimcmaster1 @jreback @simonjayhawkins