CLN: drop **kwds from pd.read_excel #34464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
read_excel_kwargs
branch
from
d39e4f8 to
62850bd
Compare
|
Lgtm if green |
jreback
requested changes
May 31, 2020
jreback
approved these changes
Jun 1, 2020
|
thanks @topper-123 |
This was referenced Aug 16, 2020
JakaKokosar
added a commit
to biolab/orange3-single-cell
that referenced
this pull request
Sep 1, 2020
This is needed until pandas-dev/pandas#34464 is addressed in data loader module
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
**kwdsfrompd.read_excel.Wrt. "new" keyword parameter
na_filter: This parameter already exists in the doc string and is just masked in thekwdsin the signature. If you follow the code paths all the way down to parsers.py, you can see that it indeed has a default of `True``.