Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read_excel signature cleanup #24487

Closed
WillAyd opened this issue Dec 29, 2018 · 2 comments
Closed

Read_excel signature cleanup #24487

WillAyd opened this issue Dec 29, 2018 · 2 comments
Labels
API - Consistency Internal Consistency of API/Behavior Clean Deprecate Functionality to remove in pandas IO Excel read_excel, to_excel

Comments

@WillAyd
Copy link
Member

WillAyd commented Dec 29, 2018

Follow up to #24423 and related to #11544 the signatures of functions for parsing excel have slight nuances to them and allow for the passing of keyword args, which may not necessarily be useful.

There's some cleanup here which could be done to align signatures and (maybe) remove keyword arguments

@WillAyd WillAyd added IO Excel read_excel, to_excel Clean labels Dec 29, 2018
@jbrockmendel jbrockmendel added the API - Consistency Internal Consistency of API/Behavior label Dec 19, 2019
@mroeschke mroeschke added Deprecate Functionality to remove in pandas and removed Enhancement labels Jun 25, 2021
@ahawryluk
Copy link
Contributor

Was this issue resolved when when **kwds was removed from pd.read_excel in #34464?

@rhshadrach
Copy link
Member

That's my take as well @ahawryluk. @WillAyd if you think there is more to do here, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Consistency Internal Consistency of API/Behavior Clean Deprecate Functionality to remove in pandas IO Excel read_excel, to_excel
Projects
None yet
Development

No branches or pull requests

5 participants