Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: GH29547 format with f-strings #34399

Merged
merged 11 commits into from
May 28, 2020
Merged

CLN: GH29547 format with f-strings #34399

merged 11 commits into from
May 28, 2020

Conversation

matteosantama
Copy link
Contributor

@matteosantama matteosantama commented May 27, 2020 •
edited
Loading

Sorry all, new PR. Didn't branch off master for the last one.

#29547

@dsaxton dsaxton added the Clean label May 27, 2020
@dsaxton
Copy link
Member

dsaxton commented May 27, 2020

Thanks @matteosantama, merging master should fix the CI

@jreback jreback added this to the 1.1 milestone May 27, 2020
@jreback jreback added the Code Style Code style, linting, code_checks label May 27, 2020
jreback
jreback requested changes May 27, 2020
View reviewed changes
pandas/util/_validators.py Outdated Show resolved Hide resolved
pandas/util/_validators.py Outdated Show resolved Hide resolved
WillAyd
WillAyd approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreback jreback merged commit ce29248 into pandas-dev:master May 28, 2020
@jreback
Copy link
Contributor

jreback commented May 28, 2020

thanks @matteosantama

@matteosantama matteosantama deleted the format branch May 28, 2020 19:17
@MatteoFelici MatteoFelici mentioned this pull request Jun 20, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@matteosantama @dsaxton @jreback @WillAyd