Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: GH29547 change string formatting with f-strings (6 files changed) #34831

Merged
merged 6 commits into from
Jun 18, 2020
Merged

CLN: GH29547 change string formatting with f-strings (6 files changed) #34831

merged 6 commits into from
Jun 18, 2020

Conversation

MatteoFelici
Copy link
Contributor

Replace old string formatting syntax with f-strings #29547

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Changed 6 files:

  • pandas/tests/io/parser/test_header.py
  • pandas/tests/io/test_sql.py
  • pandas/tests/io/test_html.py
  • pandas/tests/reductions/test_reductions.py
  • pandas/tests/reshape/test_melt.py
  • pandas/tests/scalar/timedelta/test_timedelta.py

TomAugspurger
TomAugspurger reviewed Jun 17, 2020
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left a few comments on places where the f-strings aren't an improvement.

pandas/tests/io/test_html.py Outdated Show resolved Hide resolved
pandas/tests/reshape/test_melt.py Outdated Show resolved Hide resolved
pandas/tests/scalar/timedelta/test_timedelta.py Outdated Show resolved Hide resolved
@jreback jreback added the Code Style Code style, linting, code_checks label Jun 18, 2020
@jreback jreback added this to the 1.1 milestone Jun 18, 2020
@jreback jreback merged commit 085e75e into pandas-dev:master Jun 18, 2020
@jreback
Copy link
Contributor

jreback commented Jun 18, 2020

thanks @MatteoFelici

@MatteoFelici MatteoFelici deleted the format branch June 20, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@MatteoFelici @jreback @TomAugspurger