Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Disable parallel cythonize on Windows (GH 30214) #30585

Merged
merged 5 commits into from
Jan 1, 2020
Merged

BUG: Disable parallel cythonize on Windows (GH 30214) #30585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c64a548
BUG: Disable parallel cythonize on Windows (GH 30214)
Dr-Irv Dec 31, 2019
34a5808
add blank line to whatsnew
Dr-Irv Dec 31, 2019
428bf0e
fix formatting in whatsnew
Dr-Irv Dec 31, 2019
9f779f0
Add GH comment to code in setup.py
Dr-Irv Dec 31, 2019
aaeb597
put in -j 4 in Windows CI. Don't document change in whatsnew
Dr-Irv Dec 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/azure/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- bash: |
source activate pandas-dev
conda list
python setup.py build_ext -q -i
python setup.py build_ext -q -i -j 4
python -m pip install --no-build-isolation -e .
displayName: 'Build'

Expand Down
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v1.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,8 @@ Other
- Fixed :class:`IntegerArray` returning ``inf`` rather than ``NaN`` for operations dividing by 0 (:issue:`27398`)
- Fixed ``pow`` operations for :class:`IntegerArray` when the other value is ``0`` or ``1`` (:issue:`29997`)
- Bug in :meth:`Series.count` raises if use_inf_as_na is enabled (:issue:`29478`)
- Bug in :class:`Index` where a non-hashable name could be set without raising ``TypeError`` (:issue:29069`)
Dr-Irv marked this conversation as resolved.
Show resolved Hide resolved
- Bug in :class:`Index` where a non-hashable name could be set without raising ``TypeError`` (:issue:`29069`)


.. _whatsnew_1000.contributors:

Expand Down
5 changes: 5 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,11 @@ def maybe_cythonize(extensions, *args, **kwargs):
elif parsed.j:
nthreads = parsed.j

# GH#30356 Cythonize doesn't support parallel on Windows
if is_platform_windows() and nthreads > 0:
print("Parallel build for cythonize ignored on Windows")
Dr-Irv marked this conversation as resolved.
Show resolved Hide resolved
nthreads = 0

kwargs["nthreads"] = nthreads
build_ext.render_templates(_pxifiles)
return cythonize(extensions, *args, **kwargs)
Expand Down