BUG: Disable parallel cythonize on Windows (GH 30214) #30585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Dec 31, 2019
@WillAyd If I "enable" it for Windows CI, then all compiles would run sequentially. So that wouldn't save time (assuming the parallel stuff is working now). What am I missing here? |
|
I meant should add the “-j N” flag to the build command for Windows in the CI folder. We currently don’t pass anything so Cythonization and compilation are sequential
…Sent from my iPhone
On Dec 31, 2019, at 4:04 PM, Irv Lustig ***@***.***> wrote:
Can you also enable this for Windows CI? Would be curious to see how much time it saves there
@WillAyd If I "enable" it for Windows CI, then all compiles would run sequentially. So that wouldn't save time (assuming the parallel stuff is working now). What am I missing here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
OK, I put that in the last commit |
topper-123
approved these changes
Dec 31, 2019
There was a problem hiding this comment.
I've tried this solution out, and compilation works fine for me.
Would be interesting to try parallizing on Windows when cython/cython#3262 is solved in a new Cython release.
|
thanks @Dr-Irv |
hweecat
pushed a commit
to hweecat/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAdded test in
setup.pyto check if nthreads is positive and on Windows.