Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add StataWriter 118 for unicode support #30285

Merged
merged 3 commits into from
Dec 31, 2019
Merged

ENH: Add StataWriter 118 for unicode support #30285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea7e87c
ENH: Add StataWriter 118 for unicode support
bashtage Dec 13, 2019
8b6c5ec
Merge remote-tracking branch 'upstream/master' into stata-118-writer
TomAugspurger Dec 30, 2019
3ef4ecf
Merge branch 'master' of https://github.com/pandas-dev/pandas into st…
jbrockmendel Dec 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,8 @@ Other enhancements
- DataFrame constructor preserve `ExtensionArray` dtype with `ExtensionArray` (:issue:`11363`)
- :meth:`DataFrame.sort_values` and :meth:`Series.sort_values` have gained ``ignore_index`` keyword to be able to reset index after sorting (:issue:`30114`)
- :meth:`DataFrame.to_markdown` and :meth:`Series.to_markdown` added (:issue:`11052`)

- :meth:`DataFrame.drop_duplicates` has gained ``ignore_index`` keyword to reset index (:issue:`30114`)
- Added new writer for exporting Stata dta files in version 118, ``StataWriter118``. This format supports exporting strings containing Unicode characters (:issue:`23573`)
jreback marked this conversation as resolved.
Show resolved Hide resolved

Build Changes
^^^^^^^^^^^^^
Expand Down
11 changes: 7 additions & 4 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,14 +1929,17 @@ def to_stata(
>>> df.to_stata('animals.dta') # doctest: +SKIP
"""
kwargs = {}
if version not in (114, 117):
raise ValueError("Only formats 114 and 117 supported.")
if version not in (114, 117, 118):
raise ValueError("Only formats 114, 117 and 118 are supported.")
if version == 114:
if convert_strl is not None:
raise ValueError("strl support is only available when using format 117")
raise ValueError("strl is not supported in format 114")
from pandas.io.stata import StataWriter as statawriter
else:
from pandas.io.stata import StataWriter117 as statawriter
if version == 117:
from pandas.io.stata import StataWriter117 as statawriter
else:
from pandas.io.stata import StataWriter118 as statawriter

kwargs["convert_strl"] = convert_strl

Expand Down
Loading