-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add StataWriter 118 for unicode support #30285
Conversation
90c0a5f
to
30b110b
Compare
30b110b
to
2df2a10
Compare
2df2a10
to
f12457c
Compare
@kshedden can you double-check this? It looks fine to me, but I think you're better-informed on this than I am. |
Sorry, I'm not familiar at all with the writers. |
f12457c
to
8dde917
Compare
e1d47c4
to
3cd1088
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think looks OK generally. Would have been easier to review if the refactor / f-strings were done separate
3cd1088
to
e9aa0b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think looks OK generally. Would have been easier to review if the refactor / f-strings were done separate
I'm sure this is true. Just binged on them a bit.
scikit-learn related failure |
LGTM. @TomAugspurger are we letting the sklearn thing in travis block merging? |
Nope, it's OK to ignore. |
e9aa0b0
to
303ba16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. very minor comments, pls rebase and ping on green.
Add StataWriter with unicode support
303ba16
to
ea7e87c
Compare
CI failure looked unrelated.
Merged master to see if its fixed. |
CI failure again looks unrelated (and azure won't let me re-run). merged master to force re-run. |
@jreback @jbrockmendel green. |
thanks @bashtage |
Add StataWriter with unicode support Co-authored-by: Tom Augspurger <[email protected]> Co-authored-by: jbrockmendel <[email protected]>
Add StataWriter with unicode support
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff