DEPR: remove real, imag, put, and str.partition kwarg #29986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
changed the title
|
These changes I thought would have been fine. Seem to have instead triggered multiple test failures... |
|
Looks like ptp behavior is fickle depending on numpy version, will revert that and save it for a later day |
jbrockmendel
changed the title
| result = values.str.partition(pat="_") | ||
| tm.assert_frame_equal(result, expected) | ||
| result = values.str.partition("_") | ||
| tm.assert_frame_equal(result, expected) | ||
|
|
||
| # str.rpartition | ||
| # using sep -> no warning |
There was a problem hiding this comment.
Small nit, but those comments are no longer up to date (also above)
There was a problem hiding this comment.
updated #29985 to remove these comments
|
thanks @jbrockmendel small followup indicated by @jorisvandenbossche above |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Dec 4, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.