-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: assorted (non-pytables) cleanups #29985
Conversation
pi = pd.date_range(start=pd.Timestamp("2000-01-01"), periods=100, freq=freqstr) | ||
return pi | ||
dti = pd.date_range(start=pd.Timestamp("2000-01-01"), periods=100, freq=freqstr) | ||
return dti |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just return pd.date_range(...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes look OK, but operationally speaking, I think it would have preferable to separate out some of these changes into separate PR's to facilitate review.
e.g. the whatsnew
changes don't need to be held up by the eval.py
changes.
@simonjayhawkins mypy is complaining about instantiating a class where we use abc.ABCMeta, thoughts? |
try this.. diff --git a/pandas/core/computation/engines.py b/pandas/core/computation/engines.py
index a4eaa897c..9b813bb4c 100644
--- a/pandas/core/computation/engines.py
+++ b/pandas/core/computation/engines.py
@@ -3,6 +3,7 @@ Engine classes for :func:`~pandas.eval`
"""
import abc
+from typing import Dict, Type
from pandas.core.computation.align import align_terms, reconstruct_object
from pandas.core.computation.ops import _mathops, _reductions
@@ -139,4 +140,7 @@ class PythonEngine(AbstractEngine):
pass
-_engines = {"numexpr": NumExprEngine, "python": PythonEngine}
+_engines: Dict[str, Type[AbstractEngine]] = {
+ "numexpr": NumExprEngine,
+ "python": PythonEngine,
+} |
can you rebase |
thanks @jbrockmendel if you can address @gfyoung comment in a followup |
includes a couple of whatsnew notes that fell through the cracks