Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Standardize searchsorted signatures #22670

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Sep 11, 2018

The parameter is "value" across the board.

xref #14645.

@gfyoung gfyoung added Deprecate Functionality to remove in pandas Clean labels Sep 11, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Sep 11, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

The parameter is "value" across the board.

xref pandas-devgh-14645.
@gfyoung gfyoung force-pushed the searchsorted-standardize branch from 5cd523e to eb9f65c Compare September 11, 2018 23:36
@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #22670 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22670      +/-   ##
==========================================
- Coverage   92.17%   92.17%   -0.01%     
==========================================
  Files         169      169              
  Lines       50708    50702       -6     
==========================================
- Hits        46740    46734       -6     
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.58% <100%> (-0.01%) ⬇️
#single 42.34% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.74% <ø> (-0.01%) ⬇️
pandas/core/indexes/period.py 93.48% <100%> (-0.02%) ⬇️
pandas/core/series.py 93.72% <100%> (-0.01%) ⬇️
pandas/core/base.py 97.6% <100%> (-0.01%) ⬇️
pandas/core/indexes/timedeltas.py 91.16% <100%> (-0.03%) ⬇️
pandas/core/indexes/datetimes.py 95.67% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73dd6ec...eb9f65c. Read the comment docs.

@gfyoung
Copy link
Member Author

gfyoung commented Sep 13, 2018

Anyone have objections to this PR? This is a pretty cut and dry deprecation removal.

@jreback
Copy link
Contributor

jreback commented Sep 13, 2018

lgtm

@gfyoung gfyoung merged commit ba2720b into pandas-dev:master Sep 13, 2018
@gfyoung gfyoung deleted the searchsorted-standardize branch September 14, 2018 18:10
aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Sep 20, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants