Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: correct min_count param docstring #19836

Merged
merged 4 commits into from
Feb 23, 2018
Merged

DOC: correct min_count param docstring #19836

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
178f9dc
DOC: correct min_count param docstring
ZhuBaohe Feb 22, 2018
9e8546b
reverse the logic
ZhuBaohe Feb 22, 2018
afefe9c
modify the sentence
ZhuBaohe Feb 22, 2018
22fd6bb
fixed for PEP8
ZhuBaohe Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7867,8 +7867,8 @@ def _doc_parms(cls):

.. versionadded :: 0.22.0

Added with the default being 1. This means the sum or product
of an all-NA or empty series is ``NaN``.
Added with the default being 0. This means the sum or product
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you reverse the logic of the final part here. Also can you check the consistency with other text for min_count (in this file)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverse the logic in new commit. If I understand wrong, please give me specific comments. A total of 9 functions share parameter descriptions (Series.sum, Series.prod, Series.product , DataFrame.sum, DataFrame.prod, DataFrame.product , Panel.sum, Panel.prod, Panel.product).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you find it clearer to phrase the second sentence as

This means the sum of an all-NA or empty Series is 0, and the product of an all-NA or empty Series is 1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 Already made the change

of an all-NA or empty series is ``NaN`` if min_count=1.
"""


Expand Down