DOC: correct min_count param docstring #19836
Conversation
pandas/core/generic.py
Outdated
| @@ -7867,8 +7867,8 @@ def _doc_parms(cls): | |||
|
|
|||
| .. versionadded :: 0.22.0 | |||
|
|
|||
| Added with the default being 1. This means the sum or product | |||
| of an all-NA or empty series is ``NaN``. | |||
| Added with the default being 0. This means the sum or product | |||
There was a problem hiding this comment.
can you reverse the logic of the final part here. Also can you check the consistency with other text for min_count (in this file)
There was a problem hiding this comment.
I reverse the logic in new commit. If I understand wrong, please give me specific comments. A total of 9 functions share parameter descriptions (Series.sum, Series.prod, Series.product , DataFrame.sum, DataFrame.prod, DataFrame.product , Panel.sum, Panel.prod, Panel.product).
There was a problem hiding this comment.
Do you find it clearer to phrase the second sentence as
This means the sum of an all-NA or empty Series is 0, and the product of an all-NA or empty Series is 1.
There was a problem hiding this comment.
😄 Already made the change
Codecov Report
@@ Coverage Diff @@
## master #19836 +/- ##
==========================================
+ Coverage 91.57% 91.6% +0.02%
==========================================
Files 150 150
Lines 48903 48908 +5
==========================================
+ Hits 44785 44804 +19
+ Misses 4118 4104 -14
Continue to review full report at Codecov.
|
|
Hello @ZhuBaohe! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on February 22, 2018 at 23:16 Hours UTC |
|
thanks! |
correct min_count param docstring for function ’Series.prod‘， ’Series.sum', 'DataFrame.prod', 'DataFrame.sum'
git diff upstream/master -u -- "*.py" | flake8 --diff