Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: ensure proper extension dtype's don't pickle the cache #16207

Merged
merged 1 commit into from
May 3, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented May 2, 2017

xref #16201

@jreback jreback added Compat pandas objects compatability with Numpy or Python functions Dtype Conversions Unexpected or buggy dtype conversions labels May 2, 2017
@jreback jreback added this to the 0.20.0 milestone May 2, 2017
return {k: getattr(self, k, None) for k in self._metadata}

def __setstate__(self, state):
self.__dict__.update(state)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is the default behavior if there is no __setstate__ method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I know, wanted to make it explicit :>

@codecov
Copy link

codecov bot commented May 2, 2017

Codecov Report

Merging #16207 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16207      +/-   ##
==========================================
+ Coverage   90.86%   90.89%   +0.02%     
==========================================
  Files         162      162              
  Lines       50867    50879      +12     
==========================================
+ Hits        46222    46246      +24     
+ Misses       4645     4633      -12
Flag Coverage Δ
#multiple 88.67% <100%> (+0.02%) ⬆️
#single 40.31% <41.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/dtypes/dtypes.py 95.62% <100%> (+0.58%) ⬆️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/plotting/_converter.py 65.35% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cc1d0...7dc8f9f. Read the comment docs.

@codecov
Copy link

codecov bot commented May 2, 2017

Codecov Report

Merging #16207 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16207      +/-   ##
==========================================
+ Coverage   90.86%   90.89%   +0.02%     
==========================================
  Files         162      162              
  Lines       50867    50879      +12     
==========================================
+ Hits        46222    46246      +24     
+ Misses       4645     4633      -12
Flag Coverage Δ
#multiple 88.67% <100%> (+0.02%) ⬆️
#single 40.31% <41.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/dtypes/dtypes.py 95.62% <100%> (+0.58%) ⬆️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/plotting/_converter.py 65.35% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cc1d0...7dc8f9f. Read the comment docs.

@codecov
Copy link

codecov bot commented May 2, 2017

Codecov Report

Merging #16207 into master will increase coverage by <.01%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16207      +/-   ##
==========================================
+ Coverage   90.86%   90.86%   +<.01%     
==========================================
  Files         162      162              
  Lines       50867    50881      +14     
==========================================
+ Hits        46222    46235      +13     
- Misses       4645     4646       +1
Flag Coverage Δ
#multiple 88.65% <81.25%> (ø) ⬆️
#single 40.31% <25%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/dtypes/dtypes.py 94.92% <81.25%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cc1d0...8d43cba. Read the comment docs.

@jreback jreback merged commit 154a647 into pandas-dev:master May 3, 2017
yarikoptic added a commit to neurodebian/pandas that referenced this pull request Jul 12, 2017
Version 0.20.0

* tag 'v0.20.0': (742 commits)
  RLS: v0.20.0
  DOC: Whatsnew cleanup (pandas-dev#16245)
  TST: Test CategoricalIndex in test_is_categorical (pandas-dev#16243)
  TST: xfail some bottleneck on windows (pandas-dev#16240)
  DOC, TST: Document and Test Functions in dtypes/common.py (pandas-dev#16237)
  TST: Remove __init__ statements in testing (pandas-dev#16238)
  DOC: don't include all methods/attributes of IntervalIndex (pandas-dev#16221)
  PKG: Fix ModuleNotFoundError: No module named 'pandas.formats' (pandas-dev#16239)
  RLS: v0.20.0rc2
  CLN: make submodules of pandas.util private (pandas-dev#16223)
  MAINT: Remove tm.TestCase from testing (pandas-dev#16225)
  MAINT: Complete Conversion to Pytest Idiom (pandas-dev#16201)
  DOC: add whatsnew for 0.21.0
  DEPR: correct deprecation message for datetools (pandas-dev#16202)
  API Change repr name for table schema (pandas-dev#16204)
  DOC: Remove various warnings from doc build (pandas-dev#16206)
  DOC: add whatsnew for v0.20.1
  BUG: Fixed renaming of falsey names in build_table_schema (pandas-dev#16205)
  COMPAT: ensure proper extension dtype's don't pickle the cache (pandas-dev#16207)
  REF: register custom DisplayFormatter for table schema (pandas-dev#16198)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants