DEPR: correct deprecation message for datetools

[jorisvandenbossche]

Small error in the datetools depr message I just noticed:

Before ("Day.Day"):

In [33]: from pandas import datetools

In [34]: datetools.Day(1)
/home/joris/miniconda3/envs/dev/bin/ipython:1: FutureWarning: pandas.core.datetools.Day is deprecated. Please use pandas.tseries.offsets.Day.Day instead.
  #!/home/joris/miniconda3/envs/dev/bin/python
Out[34]: <Day>

After:

In [2]: datetools.Day(1)
/home/joris/miniconda3/envs/dev/bin/ipython:1: FutureWarning: pandas.core.datetools.Day is deprecated. Please use pandas.tseries.offsets.Day instead.
  #!/home/joris/miniconda3/envs/dev/bin/python
Out[2]: <Day>

[codecov]

Codecov Report

Merging #16202 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16202      +/-   ##
==========================================
- Coverage   90.86%   90.86%   -0.01%     
==========================================
  Files         162      162              
  Lines       50871    50871              
==========================================
- Hits        46225    46223       -2     
- Misses       4646     4648       +2

Flag	Coverage Δ
#multiple	88.64% <100%> (-0.01%)	⬇️
#single	40.31% <0%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/util/depr_module.py	79.06% <100%> (ø)	⬆️
pandas/core/common.py	90.68% <0%> (-0.35%)	⬇️
pandas/core/indexes/datetimes.py	95.33% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fda22...d29e2a2. Read the comment docs.

[codecov]

Codecov Report

Merging #16202 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16202      +/-   ##
==========================================
- Coverage   90.86%   90.86%   -0.01%     
==========================================
  Files         162      162              
  Lines       50871    50871              
==========================================
- Hits        46225    46223       -2     
- Misses       4646     4648       +2

Flag	Coverage Δ
#multiple	88.64% <100%> (-0.01%)	⬇️
#single	40.31% <0%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/util/depr_module.py	79.06% <100%> (ø)	⬆️
pandas/core/common.py	90.68% <0%> (-0.35%)	⬇️
pandas/core/indexes/datetimes.py	95.33% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fda22...d29e2a2. Read the comment docs.

[TomAugspurger]

This looks good.

We can do this elsewhere, but I noticed a couple of others that should be removed / moved in datetools.

• ABCDataFrame
• ABCSeries
• ABCIndexClass
• is_integer
• is_scalar
• notnull
• normalize_date (move?)
• DateParseError (do we need to expose this?)

Moves

• is_timedelta64_dtype (maybe)
• unique : pandas.unique
• Timedelta: pandas.Timedelta

[jreback]

that entire module is deprecated I wouldn't change anything else.

[jorisvandenbossche]

Yeah, Tom, I think the other ones you listed are normally not used from that module, so in principle we should add more manual redirects, but for those it is not a priority I think.

For the normalize_date there is a normalize method on Timestamp/DatetimeIndex as alternative, so not needed to move this I think