FIX: pivot_table dropna=False drops index level names #12327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2016
|
|
||
|
|
||
| assert_equal(pv_col.index.names, names1) | ||
| assert_equal(pv_ind.columns.names, names1) |
There was a problem hiding this comment.
construct an expected frame, and use assert_frame_equal
There was a problem hiding this comment.
@jreback do you mean i need to fully rewrite test_pivot_table_dropna or just make a separate DataFrame for this case?
|
pls add a whatsnew entry (0.18.0 bug fixes) |
| @@ -540,3 +540,4 @@ of columns didn't match the number of series provided (:issue:`12039`). | |||
|
|
|||
| - Bug in ``.loc`` setitem indexer preventing the use of a TZ-aware DatetimeIndex (:issue:`12050`) | |||
| - Big in ``.style`` indexes and multi-indexes not appearing (:issue:`11655`) | |||
| - Bug in ``pivot_table`` where ``dropna`` argument drops columns and index level names (:issue:`12133`) | |||
what's new fix, reference issue
| @@ -540,3 +540,4 @@ of columns didn't match the number of series provided (:issue:`12039`). | |||
|
|
|||
| - Bug in ``.loc`` setitem indexer preventing the use of a TZ-aware DatetimeIndex (:issue:`12050`) | |||
| - Big in ``.style`` indexes and multi-indexes not appearing (:issue:`11655`) | |||
|
pls rebase/update |
5 tasks
|
closed in favor of #12650 |
|
I'll do my best to learn how to squash commits ASAP.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12133
level names are lost on
MultiIndex.from_arrays(cartesian_product(table.index.levels))