-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fixes KeyError when indexes don't overlap. #12287
Conversation
Can you edit your first post to include "Closes #10291, Closes #12133" so that Github will auto-close those issues when we merge? Also would need a release note in |
s2 = pd.Series([4, 5, 6], index=[4, 5, 6]) | ||
|
||
actual = crosstab(s1, s2) | ||
self.assertTrue(actual.empty) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
construct the actual result and use assert_frame_equal
you need a test to cover #12133 |
pls add a whatsnew as well |
thanks @tshauck |
UPD: sorry, i thought that |
if u read the comments about it does not cover 12133 |
Closes #10291