Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Rework build system #762

Closed
wants to merge 1 commit into from
Closed

Rework build system #762

wants to merge 1 commit into from

Conversation

jkillian
Copy link
Contributor

The build flow is now TS [-> via TypeScript ->] ES6 [-> via Babel ->] ES5

There are a few benefits to this commit:

  • It fixes Fix Interop with CommonJS Usage #760. Why? ES6 modules export their default content as a member called default. When we switched over in Modularize #726 to ES6 modules we introduced this problem for CommonJS consumers. Babel has a special feature that fixes this. So, we use TS then Babel to get the result we want.
  • The compilation now uses our tsconfig.json files to determine compilation options. This makes things more consistent across IDE and builds, there's no longer two separate sets of files and options to maintain.
  • Related to the previous point, our build now updates the files field of our tsconfig.json files automatically. No more manually adding files or adding files through a special IDE feature! This means that only filesGlob should be adjusted manually.

There are a few other minor tweaks, but the points above are the major parts of this PR

Build flow is now TS [-> via TypeScript ->] ES6 [-> via Babel ->] ES5
This was referenced Oct 30, 2015
@jkillian
Copy link
Contributor Author

jkillian commented Nov 3, 2015

Let's use #764 and #765 instead of introducing Babel.

@jkillian jkillian closed this Nov 3, 2015
@jkillian jkillian deleted the babel-build branch November 20, 2015 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Interop with CommonJS Usage
1 participant