This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Rework Build System #761
Closed
Rework Build System #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2015 17:13
Build flow is now TS [-> via TypeScript ->] ES6 [-> via Babel ->] ES5
|
|
||
| // hack to correctly import JS module that uses module.exports = function(){...} | ||
| import * as findupSync from "findup-sync"; | ||
| const findup = (<any>findupSync).default; |
There was a problem hiding this comment.
@weswigham Do you know if there's a better way to do this when targeting ES6 and then using Babel?
There was a problem hiding this comment.
Nevermind, I think adjusting the typings is the best bet here
|
Whoops, this should merge into master and not next. Closing this in favor of #762 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build flow is now TS [-> via TypeScript ->] ES6 [-> via Babel ->] ES5
There are a few benefits to this commit:
default. When we switched over in Modularize #726 to ES6 modules we introduced this problem for CommonJS consumers. Babel has a special feature that fixes this. So, we use TS then Babel to get the result we want.tsconfig.jsonfiles to determine compilation options. This makes things more consistent across IDE and builds, there's no longer two separate sets of files and options to maintain.filesfield of ourtsconfig.jsonfiles automatically. No more manually adding files or adding files through a special IDE feature! This means that onlyfilesGlobshould be adjusted manually.There are a few other minor tweaks, but the points above are the major parts of this PR