Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: integration tests, node home validation should be empty string #82

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: integration tests, node home validation should be empty string #82

merged 1 commit into from
Feb 16, 2024

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Jan 24, 2024 •
edited
Loading

Summary

This PR fixes integration tests as after changing the NODE_HOME env variable on node-engine to be an emtpy string paketo-buildpacks/node-engine#785 integration tets are failing.

This PR also fixes below PRs

Use Cases

  • Fixes integration tests

After merging it:

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner January 24, 2024 10:33
@pacostas pacostas force-pushed the fixing-integration-test-node-home branch from afedbff to 4f05d82 Compare January 24, 2024 10:34
@pacostas
Copy link
Contributor Author

@mhdawson Can you review it?

@pacostas
Copy link
Contributor Author

@thitch97 can you review/approve?

mhdawson
mhdawson approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacostas pacostas mentioned this pull request Jan 29, 2024
Closed
@pacostas pacostas mentioned this pull request Feb 13, 2024
Merged
5 tasks
@thitch97 thitch97 added the semver:patch A change requiring a patch version bump label Feb 16, 2024
@thitch97 thitch97 merged commit 9034114 into paketo-buildpacks:main Feb 16, 2024
8 of 9 checks passed
@pacostas pacostas mentioned this pull request Feb 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@thitch97 thitch97 thitch97 approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacostas @thitch97 @mhdawson