Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting NODE_HOME to empty string for ubi-nodejs-extension #785

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Nov 21, 2023

Summary

  • Node.js is packaged differently in ubi images. The base package for Node.js does not include the headers. There is another package nodejs-devel which includes the headers but while investigating this it seems like even if the package installed they won’t be used by default. We are discussing with the RHEL team and will likely update our extension to install that package and then set NODE_HOME to where they are installed but doing so today without some fixes might lead to different headers being in a rebuild. For now just set NODE_HOME env to an empty string so that the same headers will be used each time.

  • We also discovered we were not making the node layer available during build which we should be to consistent with the non extension case.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner November 21, 2023 13:50
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thitch97 thitch97 added semver:minor A change requiring a minor version bump semver:patch A change requiring a patch version bump and removed semver:minor A change requiring a minor version bump labels Jan 4, 2024
@thitch97 thitch97 enabled auto-merge (rebase) January 16, 2024 21:06
@thitch97 thitch97 merged commit f9ed593 into paketo-buildpacks:main Jan 16, 2024
10 checks passed
@pacostas pacostas deleted the specifying-node-home-env branch January 24, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants