Setting NODE_HOME to empty string for ubi-nodejs-extension #785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Node.js is packaged differently in ubi images. The base package for Node.js does not include the headers. There is another package nodejs-devel which includes the headers but while investigating this it seems like even if the package installed they won’t be used by default. We are discussing with the RHEL team and will likely update our extension to install that package and then set NODE_HOME to where they are installed but doing so today without some fixes might lead to different headers being in a rebuild. For now just set NODE_HOME env to an empty string so that the same headers will be used each time.
We also discovered we were not making the node layer available during build which we should be to consistent with the non extension case.
Checklist