Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPLT-810] Enable allowFontScaling by default for all citizens #6561

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Dec 17, 2024

Short description

This PR enables allowFontScaling by default for all citizens.

List of changes proposed in this pull request

  • Update io-app-design-system to 4.4.4
  • Minor refactoring to FimsSuccessBody and other screens to fix minor TS issues
  • Remove deprecated Itw… component to fix TS issue

Preview

larger-text.mp4

Related PRs

How to test

Increase or decrease the font size in the Accessibility section (Settings app) on both iOS and Android. Check that each part of the interface responds to the change.

@dmnplb dmnplb added a11y Activities related to accessibility Design System New visual language and reduction of previous UI clutter labels Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPLT-810

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.03%. Comparing base (5d0bf2f) to head (9c76602).

Files with missing lines Patch % Lines
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 0.00% 1 Missing ⚠️
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6561      +/-   ##
==========================================
- Coverage   49.33%   47.03%   -2.30%     
==========================================
  Files        1562     1561       -1     
  Lines       32178    32176       -2     
  Branches     7324     7323       -1     
==========================================
- Hits        15874    15133     -741     
- Misses      16254    16995     +741     
+ Partials       50       48       -2     
Files with missing lines Coverage Δ
.../features/design-system/core/DSLegacyListItems.tsx 71.42% <ø> (ø)
ts/features/design-system/core/DSListItems.tsx 50.00% <ø> (ø)
...pay/configuration/screens/IbanOnboardingScreen.tsx 6.66% <ø> (ø)
...tures/messages/components/Home/DS/AvatarDouble.tsx 60.00% <100.00%> (ø)
ts/screens/modal/IdentificationModal.tsx 39.33% <ø> (ø)
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 2.22% <0.00%> (ø)
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 8.82% <0.00%> (-0.27%) ⬇️

... and 61 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0bf2f...9c76602. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants