Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-429] Enable allowFontScaling by default in the IOText component #359

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Nov 18, 2024

Short description

This PR enables allowFontScaling by default in the IOText component. Previously the default was tied to the state of the isExperimental value, so it was only enabled if you enabled the experimental DS.

List of changes proposed in this pull request

  • Set allowFontScaling fallback value to true in the IOText component

How to test

Set larger text on your device and check that the text is dynamic in both standard and experimental views.

@LeleDallas
Copy link
Contributor

Tested on Android device and iOS devices and it works properly!

Android iOS
Screen.Recording.2024-12-06.at.16.05.03.mov
ScreenRecording_12-06-2024.16-11-14_1.MP4

On android I'm facing the same behavior described here.
I believe further investigation is needed to address it

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed during the meeting, we find this behavior acceptable 💫

@dmnplb dmnplb merged commit b56e04c into main Dec 17, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-429-enable-font-scaling-by-default branch December 17, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants