-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-283] Add IOScrollView
(next iteration of GradientScroll
, now deprecated) + IOScrollViewWithLargeHeader
#5704
chore(Cross): [IOAPPX-283] Add IOScrollView
(next iteration of GradientScroll
, now deprecated) + IOScrollViewWithLargeHeader
#5704
Conversation
IOScrollView
(next iteration of GradientScroll
, now deprecated) + IOScrollViewWithLargeHeader
IOScrollView
(next iteration of GradientScroll
, now deprecated) + IOScrollViewWithLargeHeader
Affected stories
|
…-of-gradientscroll
…-of-gradientscroll
…-of-gradientscroll
…-of-gradientscroll
…-of-gradientscroll
…-of-gradientscroll
…-of-gradientscroll
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5704 +/- ##
==========================================
+ Coverage 48.42% 49.40% +0.97%
==========================================
Files 1488 1608 +120
Lines 31617 31988 +371
Branches 7669 7744 +75
==========================================
+ Hits 15311 15804 +493
+ Misses 16238 16121 -117
+ Partials 68 63 -5
... and 442 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@CrisTofani Let's merge this iteration for now, unless we have something else to add. Then we can easily iterate from the first release by adding what's needed. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about merging pagopa/io-app-design-system#243 , and upgrade it in this PR before merging this one?
@CrisTofani We need to release a new version for the @giuseppedipinto's PR about |
> [!caution] > This PR depends on: > * pagopa/io-app#5704 ## Short description This PR deprecates the `GradientScroll` and `GradientBottomActions` components. > [!important] > This PR was added as part of the refactoring of the `GradientScroll` component, but we preferred to move the screen component to the main repo for easier maintenance. > To learn more about the new `IOScrollView` component, please refer to: > * pagopa/io-app#5704 ## List of changes proposed in this pull request - Add deprecation note to the `GradientScroll` and `GradientBottomActions` components ## How to test N/A --------- Co-authored-by: Cristiano Tofani <[email protected]> Co-authored-by: Mario Perrotta <[email protected]> Co-authored-by: Alice Di Rico <[email protected]>
…-of-gradientscroll
…-of-gradientscroll
…-of-gradientscroll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Short description This PR removes the `VDivider` and `EndOfPage` components. The former because it wasn't used. The latter because it's replaced by the `useScreenEndMargin` hook or space already managed by `FooterActions` or `IOScrollView`. ## List of changes proposed in this pull request - Remove mentioned components - Update example app and Storybook docs accordingly ## Related PRs Here are the PRs for the components listed above: - pagopa/io-app#5808 - pagopa/io-app#5787 - pagopa/io-app#5704
Note
This PR is the result of the discussion we had in the PR below:
GradientScrollView
forIOScrollView
io-app-design-system#243Short description
This PR add the new
IOScrollView
, next iteration of theGradientScrollView
(now officially deprecated):It also adds the new
IOScrollViewWithLargeHeader
screen component that should replaceRNavScreenWithLargeHeader
.List of changes proposed in this pull request
Add the new
IOScrollView
screen component. Compared to the previousGradientScrollView
:GradientBottomActions
because it hasn't added any advantagesnapOffset
prop to optionally configure the snap pointheaderConfig
propincludeContentMargins
boolean value to remove content margins if neededGradientScrollView
(nowIOScrollView
)actions
config objectdebugMode
so you can see the gradient area even when the end is reachedAdd the new
IOScrollViewWithLargeHeader
screen component. Compared to the previousRNavScreenWithLargeHeader
:fixedBottomSlot
because we already manage the actions at the bottom with theIOScrollView
componentPreview
three-buttons.mp4
ioscrollview.mp4
new-opacity-transition.mp4
gradient-scroll-dark-mode.mp4
As you can see from the video above, in the most extreme case you can see all kinds of buttons.
How to test