Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPX-310] Remove VDivider and EndOfPage components #277

Merged
merged 3 commits into from
Jun 4, 2024
Merged

[IOAPPX-310] Remove VDivider and EndOfPage components #277

merged 3 commits into from
Jun 4, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Jun 3, 2024 •
edited
Loading

Short description

This PR removes the VDivider and EndOfPage components. The former because it wasn't used. The latter because it's replaced by the useScreenEndMargin hook or space already managed by FooterActions or IOScrollView.

List of changes proposed in this pull request

  • Remove mentioned components
  • Update example app and Storybook docs accordingly

Related PRs

Here are the PRs for the components listed above:

@dmnplb dmnplb requested review from a team as code owners June 3, 2024 15:36
@dmnplb dmnplb merged commit 7249402 into main Jun 4, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-310-remove-not-used-components branch June 4, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @CrisTofani