Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-368] Revamp wallet transaction detail page #5282

Merged
merged 32 commits into from
Dec 4, 2023

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Nov 30, 2023

Short description

This PR integrates the revamp of the new wallet transaction detail page

List of changes proposed in this pull request

  • Added into walletV3 feature folder structure the transaction folder
  • Added the redux flow and saga mock (that doesn't make a real API request until we switch from actual PM to BIZ Event);
  • Added two new screens: WalletTransactionDetailsScreen and WalletTransactionOperationDetailsScreen
  • Added Skeletons showing up while loading some API requests;
  • Connected redux flow & sagas to the walletV3 feature store;
  • Added translation locales;
  • Edited the current navigateToTransactionDetailsScreen redirecting to the new screen;

How to test

  • Go into the transactions list from the wallet home;
  • Select any transaction from the list;
  • You should be able to see the new transaction screen;

Revamp design

https://www.figma.com/file/SDaOSTsQnJUxmoPQEfz3bJ/Ricevuta-di-pagamento-pagoPA?type=design&node-id=520-10951&mode=design&t=KSENC2iM2XXGMJaT-4

Preview

Before After
before.mov
new-transaction-details.mov

NB: In the new transaction preview video there is a 2-second forced loading to show up skeletons to showcase how the loading page looks when it is loading

@Hantex9 Hantex9 added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Nov 30, 2023
@Hantex9 Hantex9 requested review from thisisjp and a team as code owners November 30, 2023 09:58
@pagopa-github-bot pagopa-github-bot changed the title feat: [IOBP-368] Revamp wallet transaction detail page chore: [IOBP-368] Revamp wallet transaction detail page Nov 30, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 30, 2023

Affected stories

  • ⚙️ IOBP-368: Implementazione nuova schermata dettaglio transazione
    subtask of
    • IOBP-196: Integrazione IO-wallet PagoPA (Flusso on-boarding)

Generated by 🚫 dangerJS against 027d4a6

@Hantex9 Hantex9 changed the title chore: [IOBP-368] Revamp wallet transaction detail page feat: [IOBP-368] Revamp wallet transaction detail page Nov 30, 2023
@thisisjp
Copy link
Contributor

@Hantex9 what a huge change in the app 🚀

Two comments👇

  1. "Totale" should include the fee (aka it's the former "Totale pagato" field)
  2. Can we truncate after the first line in the list item with value shown in the first page?

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #5282 (027d4a6) into master (e3608af) will decrease coverage by 0.10%.
The diff coverage is 26.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5282      +/-   ##
==========================================
- Coverage   47.84%   47.74%   -0.10%     
==========================================
  Files        1565     1576      +11     
  Lines       32505    32639     +134     
  Branches     7982     8029      +47     
==========================================
+ Hits        15552    15584      +32     
- Misses      16903    17005     +102     
  Partials       50       50              
Files Coverage Δ
ts/components/ui/RNavScreenWithLargeHeader.tsx 5.88% <ø> (ø)
...s/features/walletV3/common/store/reducers/index.ts 100.00% <ø> (ø)
...atures/walletV3/transaction/store/actions/index.ts 100.00% <100.00%> (ø)
ts/navigation/AuthenticatedStackNavigator.tsx 13.04% <ø> (ø)
ts/features/walletV3/common/saga/index.ts 0.00% <0.00%> (ø)
...ures/walletV3/transaction/navigation/navigator.tsx 75.00% <75.00%> (ø)
ts/utils/stringBuilder.ts 95.83% <90.00%> (-4.17%) ⬇️
ts/features/walletV3/transaction/saga/index.ts 0.00% <0.00%> (ø)
...action/components/WalletTransactionTotalAmount.tsx 28.57% <28.57%> (ø)
ts/screens/wallet/WalletHomeScreen.tsx 2.33% <0.00%> (-0.08%) ⬇️
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3608af...027d4a6. Read the comment docs.

@pagopa-github-bot pagopa-github-bot changed the title feat: [IOBP-368] Revamp wallet transaction detail page chore: [IOBP-368] Revamp wallet transaction detail page Nov 30, 2023
@Hantex9
Copy link
Contributor Author

Hantex9 commented Nov 30, 2023

@Hantex9 what a huge change in the app 🚀

Two comments👇

  1. "Totale" should include the fee (aka it's the former "Totale pagato" field)
  2. Can we truncate after the first line in the list item with value shown in the first page?
  1. Addressed into 378a646
  2. Actually the component ListItemInfo doesn't allow to set a max number of lines to the title, maybe it could be addressed by @dmnplb ?

Preview of grandTotal

@Hantex9 Hantex9 merged commit cfb18dd into master Dec 4, 2023
8 checks passed
@Hantex9 Hantex9 deleted the IOBP-368-new-wallet-transaction-detail branch December 4, 2023 13:53
dmnplb added a commit that referenced this pull request Dec 11, 2023
…y main screen (Profile) (#5280)

> [!caution]
> This PR depends on #5282 because
`RNavScreenWithLargeHeader` has slightly changed to fit the design of
the new wallet transaction detail screen.

## Short description
This PR adds the new `RNavScreenWithLargeHeader` component to the
`Privacy Policy` main screen.

## List of changes proposed in this pull request
- Fix typographic style in the `RNavScreenWithLargeHeader`
(0c6417d)
- Add RNavScreenWithLargeHeader to the Privacy main screen
(5f8ad29)

### Preview

https://github.com/pagopa/io-app/assets/1255491/c0e37f43-9094-4417-afe5-4579152b8963

## How to test
Go to the Profile → Privacy Policy

---------

Co-authored-by: Alessandro Izzo <[email protected]>
Co-authored-by: Alessandro Izzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants