Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPFD0-196] Add LargeHeader header style to Privacy Policy main screen (Profile) #5280

Merged
merged 10 commits into from
Dec 11, 2023

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Nov 29, 2023

Caution

This PR depends on #5282 because RNavScreenWithLargeHeader has slightly changed to fit the design of the new wallet transaction detail screen.

Short description

This PR adds the new RNavScreenWithLargeHeader component to the Privacy Policy main screen.

List of changes proposed in this pull request

  • Fix typographic style in the RNavScreenWithLargeHeader (0c6417d)
  • Add RNavScreenWithLargeHeader to the Privacy main screen (5f8ad29)

Preview

large-header-privacy-policy.mp4

How to test

Go to the Profile → Privacy Policy

@dmnplb dmnplb requested a review from a team as a code owner November 29, 2023 16:58
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPFD0-196] Add LargeHeader header style to Privacy Policy main screen (Profile) chore: [IOAPPFD0-196] Add LargeHeader header style to Privacy Policy main screen (Profile) Nov 29, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 29, 2023

Affected stories

  • ⚙️ IOAPPFD0-196: LargeHeader nella schermata di Privacy e condizioni d'uso
    subtask of

Generated by 🚫 dangerJS against f95164a

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #5280 (9d63792) into master (2424f2c) will increase coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 65.00%.

❗ Current head 9d63792 differs from pull request most recent head f95164a. Consider uploading reports for the commit f95164a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5280      +/-   ##
==========================================
+ Coverage   47.83%   47.90%   +0.06%     
==========================================
  Files        1594     1594              
  Lines       33195    33192       -3     
  Branches     8226     8226              
==========================================
+ Hits        15880    15900      +20     
+ Misses      17251    17228      -23     
  Partials       64       64              
Files Coverage Δ
ts/components/ui/RNavScreenWithLargeHeader.tsx 76.47% <ø> (+70.58%) ⬆️
ts/screens/profile/PrivacyMainScreen.tsx 87.14% <80.00%> (ø)
ts/navigation/ProfileNavigator.tsx 33.33% <20.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3247dc3...f95164a. Read the comment docs.

Copy link

dpulls bot commented Dec 4, 2023

🎉 All dependencies have been resolved !

@dmnplb dmnplb merged commit 6f65582 into master Dec 11, 2023
5 checks passed
@dmnplb dmnplb deleted the IOAPPFD0-196-large-header-privacy-policy branch December 11, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants