Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#177456804] Footer on bonus information screen has a wrong text #2986

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

CaraDune
Copy link
Contributor

@CaraDune CaraDune commented Apr 15, 2021

this is the correct copy for the Legal Team - thanks guys

this is the correct copy for the Legal Team - thanks guys
@CrisTofani CrisTofani changed the title update cgn footer for guide and privacy policy [#177456804] Footer on bonus information screen has a wrong text Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #2986 (f40c5f8) into master (c960439) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head f40c5f8 differs from pull request most recent head a35f765. Consider uploading reports for the commit a35f765 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2986      +/-   ##
==========================================
- Coverage   59.20%   59.08%   -0.13%     
==========================================
  Files         915      910       -5     
  Lines       25184    25062     -122     
  Branches     4668     4637      -31     
==========================================
- Hits        14911    14808     -103     
+ Misses      10174    10155      -19     
  Partials       99       99              
Impacted Files Coverage Δ
...tails/components/iban/IbanInformationComponent.tsx 72.22% <0.00%> (-1.47%) ⬇️
...s/features/bonus/bpd/store/actions/transactions.ts 100.00% <0.00%> (ø)
...features/bonus/bpd/store/reducers/details/index.ts 100.00% <0.00%> (ø)
.../store/reducers/details/transactionsv2/daysInfo.ts
...us/bpd/store/reducers/details/transactionsv2/ui.ts
...bpd/store/reducers/details/transactionsv2/index.ts
.../store/reducers/details/transactionsv2/entities.ts
...rs/details/transactionsv2/__mock__/transactions.ts
...re/reducers/details/activation/technicalAccount.ts 84.00% <0.00%> (+4.68%) ⬆️
...s/components/iban/BaseIbanInformationComponent.tsx 80.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c960439...a35f765. Read the comment docs.

Copy link
Contributor

@debiff debiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the italian version is a bit different.

termsAndConditionFooter: "Premendo \"{{ctaText}}\" dichiari di aver letto e compreso la [guida]({{regulationLink}}) e l'[informativa sul trattamento dei dati personali]({{tosUrl}}) del servizio."

fabriziofff
fabriziofff previously approved these changes Apr 16, 2021
@fabriziofff fabriziofff dismissed their stale review April 16, 2021 13:21

Some changes are required

@CaraDune
Copy link
Contributor Author

changes are now ok - requesting UX review from @thisisjp and/or @Loreau

@thisisjp
Copy link
Contributor

@CaraDune looks good to me but I don't have any context... is this valid for all bonuses\initiatives?

@CrisTofani
Copy link
Contributor

CrisTofani commented Apr 19, 2021

@CaraDune looks good to me but I don't have any context... is this valid for all bonuses\initiatives?

@thisisjp Yes this is the footer text that appears at the bottom of the bonus description screen
image

(note: the screen above refers to the text before @CaraDune's changes)

@CrisTofani CrisTofani merged commit caae4d1 into pagopa:master Apr 19, 2021
@CaraDune
Copy link
Contributor Author

@thisisjp yes, it is the footer for the general CTA. I made a mistake earlier because I assumed it was specific for CGN but it wasn't the case, so I crafted a general text.
Please note that the screenshot that @CrisTofani posted does not reflect the changes we are committing. the new text is: by pressing [CTA] you declare that you have read and understood the [Guide] and the [Privacy Policy]

@CaraDune CaraDune deleted the patch-1 branch April 19, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants