Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numberOfLines and textAlign props to ButtonLink #375

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add numberOfLines and textAlign props to ButtonLink #375

merged 2 commits into from
Jan 7, 2025

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Jan 7, 2025

Short description

This PR adds numberOfLines and textAlign props to ButtonLink. This change is necessary to fix some issues when text is larger and the text is truncated (e.g. Forgot unlock code action in this screen)

List of changes proposed in this pull request

  • Add the mentioned props to ButtonLink
  • Update example app with this edge case

How to test

  1. Run the example app
  2. Go to the Buttons screen

@dmnplb dmnplb requested review from a team as code owners January 7, 2025 10:28
@dmnplb dmnplb merged commit 08f56c9 into main Jan 7, 2025
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-457-add-additional-props-buttonlink branch January 7, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeleDallas LeleDallas LeleDallas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @LeleDallas