Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implementing pip-9 #706

Merged
merged 2 commits into from
Sep 26, 2023
Merged

feat: implementing pip-9 #706

merged 2 commits into from
Sep 26, 2023

Conversation

amirvalhalla
Copy link
Member

@amirvalhalla amirvalhalla commented Sep 19, 2023 •
edited by b00f
Loading

Description

This PR implemented pip-9.

@amirvalhalla amirvalhalla self-assigned this Sep 19, 2023
@Ja7ad
Copy link
Contributor

Ja7ad commented Sep 19, 2023

Description

this PR implemented pip-9

Your proposal is Draft and not accepted by team, how to implement?

@b00f

@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #706 (15cbe2f) into main (59c0d89) will increase coverage by 0.00%.
The diff coverage is 92.30%.

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files         169      168    -1     
  Lines        7889     7825   -64     
=======================================
- Hits         6586     6533   -53     
+ Misses       1009      998   -11     
  Partials      294      294

@b00f
Copy link
Collaborator

b00f commented Sep 19, 2023

@Ja7ad It is not merged yet. Waiting for the approval.

kehiy
kehiy reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@kehiy kehiy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.
We can merge it after PIP-9 is accepted by the pactus lab.
Also, that's good to add something like: removing the stamp from transaction at the end of the PR title.

@amirvalhalla Thanks

@amirvalhalla
Copy link
Member Author

Everything looks good. We can merge it after PIP-9 is accepted by the pactus lab. Also, that's good to add something like: removing the stamp from transaction at the end of the PR title.

@amirvalhalla Thanks

@kehiy
I don't think so, we need to mention it at the end of PR title, because we referred it to PIP-9

@kehiy
Copy link
Contributor

kehiy commented Sep 20, 2023

I don't think so, we need to mention it at the end of PR title, because we referred it to PIP-9

That makes sense too, it's up to you.

@b00f b00f merged commit 7c14d41 into pactus-project:main Sep 26, 2023
13 checks passed
amirvalhalla added a commit to amirvalhalla/pactus that referenced this pull request Sep 26, 2023
@b00f @kehiy
@allnil @amirvalhalla
Pip 8 update (#2)
ee42e98 
* test: fixing a broken test (pactus-project#705)

* feat: new API to get Public key by address (pactus-project#704)

Co-authored-by: b00f <[email protected]>

* chore(lint): enable nonamedreturns linter (pactus-project#707)

* feat: implementing pip-9 (pactus-project#706)

* fix: fixing gui issues

---------

Co-authored-by: Kay <[email protected]>
Co-authored-by: allnil <[email protected]>
Co-authored-by: Amir Babazadeh <[email protected]>
amirvalhalla added a commit to amirvalhalla/pactus that referenced this pull request Sep 26, 2023
@b00f @kehiy
@allnil @amirvalhalla
Pip 8 update2 (#3)
4acd840 
* test: fixing a broken test (pactus-project#705)

* feat: new API to get Public key by address (pactus-project#704)

Co-authored-by: b00f <[email protected]>

* temp

* chore(lint): enable nonamedreturns linter (pactus-project#707)

* feat: implementing pip-9 (pactus-project#706)

* fix: fixing gui issues

---------

Co-authored-by: Kay <[email protected]>
Co-authored-by: allnil <[email protected]>
Co-authored-by: Amir Babazadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kehiy kehiy kehiy left review comments

@b00f b00f b00f approved these changes

@yenkhoon yenkhoon Awaiting requested review from yenkhoon

@vlasfama vlasfama Awaiting requested review from vlasfama

@Ja7ad Ja7ad Awaiting requested review from Ja7ad

@themantre themantre Awaiting requested review from themantre

Assignees

@amirvalhalla amirvalhalla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amirvalhalla @Ja7ad @b00f @kehiy