Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new API to get Public key by address #704

Merged
merged 13 commits into from
Sep 19, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 19, 2023

Description

Related issue(s)

If this Pull Request is related to an issue, mention it here.

@kehiy kehiy requested review from b00f and Ja7ad September 19, 2023 10:12
@kehiy kehiy added the www label Sep 19, 2023
@kehiy kehiy self-assigned this Sep 19, 2023
node/node.go Outdated Show resolved Hide resolved
www/grpc/blockchain.go Outdated Show resolved Hide resolved
www/grpc/blockchain_test.go Outdated Show resolved Hide resolved
www/grpc/blockchain_test.go Outdated Show resolved Hide resolved
www/grpc/grpc-gateway.config.yaml Outdated Show resolved Hide resolved
www/grpc/server.go Outdated Show resolved Hide resolved
www/http/http_test.go Outdated Show resolved Hide resolved
@kehiy kehiy requested a review from b00f September 19, 2023 10:44
state/facade.go Outdated Show resolved Hide resolved
state/mock.go Outdated Show resolved Hide resolved
state/state.go Outdated Show resolved Hide resolved
@kehiy kehiy requested a review from b00f September 19, 2023 11:48
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #704 (2232a14) into main (d79b215) will increase coverage by 0.03%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   83.46%   83.49%   +0.03%     
==========================================
  Files         169      169              
  Lines        7879     7888       +9     
==========================================
+ Hits         6576     6586      +10     
  Misses       1008     1008              
+ Partials      295      294       -1     

@b00f
Copy link
Collaborator

b00f commented Sep 19, 2023

@kehiy Thanks. Let's merge

@kehiy kehiy merged commit 113d0fc into pactus-project:main Sep 19, 2023
12 checks passed
@kehiy kehiy deleted the feature/grpcGetPubKey branch September 19, 2023 13:08
amirvalhalla added a commit to amirvalhalla/pactus that referenced this pull request Sep 26, 2023
* test: fixing a broken test (pactus-project#705)

* feat: new API to get Public key by address (pactus-project#704)

Co-authored-by: b00f <[email protected]>

* chore(lint): enable nonamedreturns linter (pactus-project#707)

* feat: implementing pip-9 (pactus-project#706)

* fix: fixing gui issues

---------

Co-authored-by: Kay <[email protected]>
Co-authored-by: allnil <[email protected]>
Co-authored-by: Amir Babazadeh <[email protected]>
amirvalhalla added a commit to amirvalhalla/pactus that referenced this pull request Sep 26, 2023
* test: fixing a broken test (pactus-project#705)

* feat: new API to get Public key by address (pactus-project#704)

Co-authored-by: b00f <[email protected]>

* temp

* chore(lint): enable nonamedreturns linter (pactus-project#707)

* feat: implementing pip-9 (pactus-project#706)

* fix: fixing gui issues

---------

Co-authored-by: Kay <[email protected]>
Co-authored-by: allnil <[email protected]>
Co-authored-by: Amir Babazadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding new API to get Public key by address
2 participants