Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pip reference for Flags in transaction data #675

Closed
wants to merge 1 commit into from

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 4, 2023

Description

added the pip reference of Flags in transaction data.

@kehiy kehiy added Documentation Improvements or additions to documentation enhancement New feature or request labels Sep 4, 2023
@kehiy kehiy requested a review from b00f September 4, 2023 08:44
@kehiy kehiy changed the title chore: add pip reference chore: add pip reference for Flags in transaction Sep 4, 2023
@kehiy kehiy changed the title chore: add pip reference for Flags in transaction chore: add pip reference for Flags in transaction data Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #675 (b5714e0) into main (85f3063) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   83.70%   83.72%   +0.02%     
==========================================
  Files         167      167              
  Lines        8008     8008              
==========================================
+ Hits         6703     6705       +2     
+ Misses       1002     1001       -1     
+ Partials      303      302       -1     

@themantre
Copy link
Contributor

We have referenced PIP in the PR #671
The comments in the code should primarily focus on providing information about the code itself, rather than referencing external resources.
Thank you for your understanding.

@themantre themantre closed this Sep 7, 2023
@kehiy kehiy deleted the feature/pip-4 branch September 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants