Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing pip-0004 indexing public key #671

Merged
merged 10 commits into from
Sep 1, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 1, 2023

implementation of PIP-4: Indexing Public Keys

@kehiy kehiy added the Breaking Changes It Contains some Changes that might not be backward compatible label Sep 1, 2023
@kehiy kehiy requested a review from b00f September 1, 2023 11:48
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #671 (701d1c1) into main (b51c1d6) will decrease coverage by 0.16%.
The diff coverage is 81.12%.

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   83.89%   83.73%   -0.16%     
==========================================
  Files         163      166       +3     
  Lines        7929     8005      +76     
==========================================
+ Hits         6652     6703      +51     
- Misses        978      998      +20     
- Partials      299      304       +5     

store/block.go Show resolved Hide resolved
@kehiy kehiy force-pushed the indexing-public-key branch from 7ef7d8f to 7f54e35 Compare September 1, 2023 12:13
store/store.go Outdated Show resolved Hide resolved
types/block/errors.go Show resolved Hide resolved
types/tx/errors.go Show resolved Hide resolved
types/tx/tx.go Outdated Show resolved Hide resolved
types/tx/tx_test.go Outdated Show resolved Hide resolved
@kehiy kehiy force-pushed the indexing-public-key branch from 59513ff to 5d88699 Compare September 1, 2023 13:52
@kehiy kehiy force-pushed the indexing-public-key branch from a0180ff to cf5f29d Compare September 1, 2023 13:53
@kehiy kehiy requested a review from b00f September 1, 2023 14:06
store/store.go Show resolved Hide resolved
store/mock.go Outdated Show resolved Hide resolved
types/block/block_test.go Outdated Show resolved Hide resolved
types/block/block_test.go Outdated Show resolved Hide resolved
@kehiy kehiy force-pushed the indexing-public-key branch from 0f14572 to 09b46ba Compare September 1, 2023 16:29
@kehiy kehiy requested a review from b00f September 1, 2023 16:29
types/tx/tx_test.go Outdated Show resolved Hide resolved
types/tx/tx_test.go Outdated Show resolved Hide resolved
@kehiy kehiy force-pushed the indexing-public-key branch from 289ddd0 to 975e434 Compare September 1, 2023 16:37
types/tx/tx_test.go Outdated Show resolved Hide resolved
@b00f b00f merged commit 5ec7759 into pactus-project:main Sep 1, 2023
12 checks passed
allahbakhsh pushed a commit to pactus-project/PIPs that referenced this pull request Sep 4, 2023
* feat: pip-0004

* fix: md lint issue

* fix: unessesary field

* refactor: enhance Security Considerations

* refactor: enhance pip-0004

* chore: linter issue

* chore: HTML issue

* fix: status changed to final 

Fixed pactus-project/pactus#671

---------

Co-authored-by: Javad Rajabzadeh <[email protected]>
@kehiy kehiy deleted the indexing-public-key branch September 9, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Changes It Contains some Changes that might not be backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants