-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implementing pip-0004 indexing public key
#671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kehiy
added
the
Breaking Changes
It Contains some Changes that might not be backward compatible
label
Sep 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #671 +/- ##
==========================================
- Coverage 83.89% 83.73% -0.16%
==========================================
Files 163 166 +3
Lines 7929 8005 +76
==========================================
+ Hits 6652 6703 +51
- Misses 978 998 +20
- Partials 299 304 +5 |
b00f
reviewed
Sep 1, 2023
kehiy
force-pushed
the
indexing-public-key
branch
from
September 1, 2023 12:13
7ef7d8f
to
7f54e35
Compare
b00f
requested changes
Sep 1, 2023
b00f
reviewed
Sep 1, 2023
b00f
reviewed
Sep 1, 2023
b00f
reviewed
Sep 1, 2023
kehiy
force-pushed
the
indexing-public-key
branch
from
September 1, 2023 13:52
59513ff
to
5d88699
Compare
kehiy
force-pushed
the
indexing-public-key
branch
from
September 1, 2023 13:53
a0180ff
to
cf5f29d
Compare
b00f
reviewed
Sep 1, 2023
b00f
reviewed
Sep 1, 2023
b00f
reviewed
Sep 1, 2023
b00f
reviewed
Sep 1, 2023
kehiy
force-pushed
the
indexing-public-key
branch
from
September 1, 2023 16:29
0f14572
to
09b46ba
Compare
b00f
approved these changes
Sep 1, 2023
kehiy
force-pushed
the
indexing-public-key
branch
from
September 1, 2023 16:37
289ddd0
to
975e434
Compare
b00f
reviewed
Sep 1, 2023
b00f
approved these changes
Sep 1, 2023
allahbakhsh
pushed a commit
to pactus-project/PIPs
that referenced
this pull request
Sep 4, 2023
* feat: pip-0004 * fix: md lint issue * fix: unessesary field * refactor: enhance Security Considerations * refactor: enhance pip-0004 * chore: linter issue * chore: HTML issue * fix: status changed to final Fixed pactus-project/pactus#671 --------- Co-authored-by: Javad Rajabzadeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of PIP-4: Indexing Public Keys