Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(daemon): add import command to download pruned snapshots #1424
feat(daemon): add import command to download pruned snapshots #1424
Changes from 6 commits
151923a
ac39a5b
cc1eee3
eab634f
cb0ab9b
358c3cb
da348d0
2203b0c
36e7d3c
0f19bdd
38caa3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 21 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L19-L21
Check warning on line 23 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L23
Check warning on line 26 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L25-L26
Check warning on line 30 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L28-L30
Check warning on line 33 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L32-L33
Check warning on line 36 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L35-L36
Check warning on line 39 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L38-L39
Check warning on line 42 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L41-L42
Check warning on line 45 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L44-L45
Check warning on line 47 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L47
Check warning on line 52 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L50-L52
Check warning on line 54 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L54
Check warning on line 57 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L57
Check warning on line 60 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L59-L60
Check warning on line 63 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L63
Check warning on line 71 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L65-L71
Check warning on line 73 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L73
Check warning on line 78 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L76-L78
Check warning on line 80 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L80
Check warning on line 85 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L83-L85
Check warning on line 87 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L87
Check warning on line 93 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L90-L93
Check warning on line 96 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can use
cmd.PromptInputWithRange
for this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ja7ad use
cmd
as it provide useful functions for interactive command linesCheck warning on line 101 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L98-L101
Check warning on line 104 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L103-L104
Check warning on line 106 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L106
Check warning on line 111 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L109-L111
Check warning on line 114 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L113-L114
Check warning on line 116 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L116
Check warning on line 124 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L118-L124
Check warning on line 128 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L127-L128
Check warning on line 132 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L131-L132
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better we move the whole extracted directory
Check warning on line 135 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L134-L135
Check warning on line 138 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L137-L138
Check warning on line 140 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L140
Check warning on line 147 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L142-L147
Check warning on line 153 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L152-L153
Check warning on line 163 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L155-L163
Check warning on line 165 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L165
Check warning on line 169 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L169
Check warning on line 173 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L171-L173
Check warning on line 176 in cmd/daemon/import.go
Codecov / codecov/patch
cmd/daemon/import.go#L176
Check warning on line 27 in cmd/daemon/main.go
Codecov / codecov/patch
cmd/daemon/main.go#L27