-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(daemon): add import command to download pruned snapshots #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
requested changes
Jul 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
==========================================
- Coverage 76.73% 75.39% -1.35%
==========================================
Files 218 220 +2
Lines 11225 11455 +230
==========================================
+ Hits 8614 8637 +23
- Misses 2192 2402 +210
+ Partials 419 416 -3 |
b00f
requested changes
Jul 19, 2024
cmd/daemon/import.go
Outdated
|
||
var choice int | ||
fmt.Printf("Please select a snapshot [1-%d]: ", len(metadata)) | ||
_, err = fmt.Scanf("%d", &choice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ja7ad use cmd
as it provide useful functions for interactive command lines
b00f
reviewed
Jul 19, 2024
b00f
approved these changes
Jul 19, 2024
b00f
changed the title
feat(cli): add import command to download snapshots
feat(daemon): add import command to download snapshots
Jul 19, 2024
b00f
changed the title
feat(daemon): add import command to download snapshots
feat(daemon): add import command to download pruned snapshots
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Import pruned snapshot form centralized server in CLI.
https://pips.pactus.org/PIPs/pip-27#importing-data
Related issue(s)