Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pip-0004, Indexing Public Keys #8

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Adding pip-0004, Indexing Public Keys #8

merged 8 commits into from
Sep 4, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Aug 27, 2023

No description provided.

@github-actions github-actions bot added the w-ci label Aug 27, 2023
@Ja7ad Ja7ad requested a review from allahbakhsh August 28, 2023 12:40
@github-actions
Copy link

The commit c467b03 (as a parent of 5721e95) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci label Aug 29, 2023
@b00f
Copy link
Collaborator

b00f commented Aug 30, 2023 •
edited
Loading

@kehiy @allahbakhsh @Ja7ad

Changing Flags bits won't change the transaction hash. So an adversary can't change the transaction hash by manipulating the Flags bits.

@kehiy kehiy mentioned this pull request Sep 1, 2023
Merged
@b00f
Copy link
Collaborator

b00f commented Sep 3, 2023 •
edited
Loading

Time Complexity of IO should be compared by Space complexity of removing the public key.
Also, check how we can keep public key in memory by address.

@github-actions github-actions bot added s-final and removed s-draft labels Sep 4, 2023
@allahbakhsh allahbakhsh merged commit cf083dd into pactus-project:main Sep 4, 2023
@kehiy kehiy deleted the feature/pip-0004 branch September 4, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allahbakhsh allahbakhsh allahbakhsh approved these changes

Assignees
No one assigned
Labels
c-new s-final
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kehiy @b00f @allahbakhsh @Ja7ad