Deprecate production_build in favour of upstream_koji_build #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 20s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 25s |
jpopelka
approved these changes
Sep 15, 2022
softwarefactory-project-zuul bot
added a commit
to packit/packit-service
that referenced
this pull request
Oct 11, 2022
Deprecate production_build in favour of upstream_koji_build Deprecate also the build alias since it's too generic. Fixes: packit/packit#1658 Requires: packit/packit#1728 Documentation: packit/packit.dev#527 RELEASE NOTES BEGIN There are two changes in the naming of the service jobs: The build job type name has been deprecated. It aimed to be an alias when Packit supported just one build type. There are currently more types of builds and just build can be misleading. Please, be explicit and use copr_build instead. The production_build name for upstream Koji build is misleading because it is not used to run production/non-scratch builds and because it can be confused with the koji_build job that is triggered for dist-git commits. (The koji_build job can trigger both scratch and non-scratch/production builds.) To be explicit, use upstream_koji_build for builds triggered in upstream and koji_build for builds triggered in downstream. Users will get a neutral status describing the change when the old names are in use. The status will become a warning starting in November and the old names will be removed by the end of the year. RELEASE NOTES END Reviewed-by: Tomas Tomecek <[email protected]> Reviewed-by: Laura Barcziová <None>
Signed-off-by: Frantisek Lachman <[email protected]>
Signed-off-by: Frantisek Lachman <[email protected]>
Signed-off-by: Frantisek Lachman <[email protected]>
lachmanfrantisek
force-pushed
the
new-job-names
branch
from
44ae40d to
4ebfa0d
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 11s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 14s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate also the
buildalias since it's too generic.Related to packit/packit-service#1656 and packit/packit#1728