Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate production_build in favour of upstream_koji_build #1656

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Deprecate production_build in favour of upstream_koji_build #1656

merged 5 commits into from
Oct 11, 2022

Conversation

lachmanfrantisek
Copy link
Member

@lachmanfrantisek lachmanfrantisek commented Sep 15, 2022 •
edited
Loading

Deprecate also the build alias since it's too generic.

Fixes: packit/packit#1658
Requires: packit/packit#1728
Documentation: packit/packit.dev#527

RELEASE NOTES BEGIN
There are two changes in the naming of the service jobs:
The build job type name has been deprecated. It aimed to be an alias when Packit supported just one build type.
There are currently more types of builds and just build can be misleading. Please, be explicit and use copr_build instead.
The production_build name for upstream Koji build is misleading because it is not used to run production/non-scratch builds and because it can be confused with the koji_build job that is triggered for dist-git commits.
(The koji_build job can trigger both scratch and non-scratch/production builds.)
To be explicit, use upstream_koji_build for builds triggered in upstream and koji_build for builds triggered in downstream.
Users will get a neutral status describing the change when the old names are in use. The status will become a warning starting in November and the old names will be removed by the end of the year.
RELEASE NOTES END

This was referenced Sep 15, 2022
Merged
Merged
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ pre-commit SUCCESS in 1m 59s
❌ packit-service-tests FAILURE in 1m 46s
❌ packit-service-tests-openshift FAILURE in 16m 02s

softwarefactory-project-zuul bot added a commit to packit/packit that referenced this pull request Sep 16, 2022
@softwarefactory-project-zuul
Merge pull request #1728 from lachmanfrantisek/new-job-names
3efc790 
Deprecate `production_build` in favour of `upstream_koji_build`

Deprecate also the build alias since it's too generic.
Signed-off-by: Frantisek Lachman [email protected]
Related to: #1658
Merge before: packit/packit-service#1656
... no release notes here, will be covered in the service PR

Reviewed-by: Jiri Popelka <None>
Reviewed-by: None <None>
Reviewed-by: Laura Barcziová <None>
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ pre-commit SUCCESS in 1m 49s
❌ packit-service-tests FAILURE in 1m 58s
✔️ packit-service-tests-openshift SUCCESS in 11m 21s

TomasTomecek
TomasTomecek approved these changes Sep 20, 2022
View reviewed changes
packit_service/worker/jobs.py Outdated Show resolved Hide resolved
lbarcziova
lbarcziova approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! would it make sense to write somewhere down how to do the deprecation (the neutral and error statuses) so that we behave consistently in the future? (although, we also want to work on packit/research#159, so I am not sure how relevant it will be)

@lachmanfrantisek
Refactor report_task_accepted
631ff3e 
Signed-off-by: Frantisek Lachman <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 3m 00s
✔️ packit-service-tests SUCCESS in 2m 21s
✔️ packit-service-tests-openshift SUCCESS in 13m 11s

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Oct 11, 2022 •
edited
Loading

nice! would it make sense to write somewhere down how to do the deprecation (the neutral and error statuses) so that we behave consistently in the future? (although, we also want to work on packit/research#159, so I am not sure how relevant it will be)

Ideally, I would go with the automated fixes next time we need to change anything.

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Oct 11, 2022 •
edited
Loading

BTW, I've fixed the tests, added a new test case covering the deprecation and restructured the changes across commits to make it more clear... @TomasTomecek @lbarcziova Could you please take another look?

@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 3m 00s
✔️ packit-service-tests SUCCESS in 3m 01s
✔️ packit-service-tests-openshift SUCCESS in 16m 25s

TomasTomecek
TomasTomecek approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice work with the commit split

lbarcziova
lbarcziova approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lachmanfrantisek lachmanfrantisek added the mergeit When set, zuul wil gate and merge the PR. label Oct 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ pre-commit SUCCESS in 2m 45s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 85b02fc into packit:main Oct 11, 2022
softwarefactory-project-zuul bot added a commit to packit/packit.dev that referenced this pull request Oct 14, 2022
@softwarefactory-project-zuul
Merge pull request #527 from lachmanfrantisek/new-job-names
e327740 
Deprecate production_build in favour of upstream_koji_build

Deprecate also the build alias since it's too generic.
Related to packit/packit-service#1656 and packit/packit#1728

Reviewed-by: Jiri Popelka <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

@TomasTomecek TomasTomecek TomasTomecek approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename and deprecate production_build
3 participants
@lachmanfrantisek @TomasTomecek @lbarcziova