Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spell file extensions parameter #2001

Merged

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Oct 24, 2022

Related #1997

@nvuillam questions:

  1. What about: https://github.com/oxsecurity/megalinter/blob/main/.automation/build.py#L1255 ???
  2. I don't know if the descriptor change is correct, I want to expose that parameter but without a default value so it would behave like now without any behaviour change.

@bdovaz bdovaz changed the title Feature/add cspell file extensions parameter Add spell file extensions parameter Oct 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2001 (20261a8) into main (a47459f) will increase coverage by 0.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
+ Coverage   82.03%   82.71%   +0.67%     
==========================================
  Files         157      157              
  Lines        3384     3384              
==========================================
+ Hits         2776     2799      +23     
+ Misses        608      585      -23     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py 89.01% <0.00%> (+8.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz check comments :)

  • update CHANGELOG.md :)

@@ -3,6 +3,8 @@ descriptor_type: other
descriptor_flavors:
- all_flavors # Applicable to CI in any language project
- cupcake
file_extensions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want default behaviour to remain the current one :)
So please don't update the descriptor ^^

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if I don't update the descriptor, neither the schema nor the documentation will be updated to reflect that the SPELL_*_FILE_EXTENSIONS parameter can be set, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that even removing that second condition won't work because the value of "lint_all_other_linters_files" is set to true: https://github.com/bdovaz/megalinter/blob/main/megalinter/descriptors/spell.megalinter-descriptor.yml

The condition in the script you mentioned compares it to false

megalinter/utils.py Outdated Show resolved Hide resolved
@bdovaz
Copy link
Collaborator Author

bdovaz commented Oct 24, 2022

Plz check comments :)

  • update CHANGELOG.md :)

Updated

@bdovaz
Copy link
Collaborator Author

bdovaz commented Oct 28, 2022

@nvuillam Can you help me to unlock this PR? Thank you.

There is some unresolved conversation I need your guidance on.

@nvuillam
Copy link
Member

@bdovaz the PR seems fine to me , but i've not validated it yet because it's still in status "draft" :)
You can merge conflicts and declare it as ready for merge, and i'll manage it :)

@bdovaz bdovaz marked this pull request as ready for review October 29, 2022 10:33
@bdovaz
Copy link
Collaborator Author

bdovaz commented Oct 29, 2022

@nvuillam done!

@nvuillam nvuillam merged commit e727b74 into oxsecurity:main Oct 29, 2022
@nvuillam
Copy link
Member

Thanks a lot for your contribution :)

@bdovaz bdovaz deleted the feature/add-cspell-file-extensions-parameter branch October 29, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants