-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spell file extensions parameter #2001
Add spell file extensions parameter #2001
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2001 +/- ##
==========================================
+ Coverage 82.03% 82.71% +0.67%
==========================================
Files 157 157
Lines 3384 3384
==========================================
+ Hits 2776 2799 +23
+ Misses 608 585 -23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz check comments :)
- update CHANGELOG.md :)
@@ -3,6 +3,8 @@ descriptor_type: other | |||
descriptor_flavors: | |||
- all_flavors # Applicable to CI in any language project | |||
- cupcake | |||
file_extensions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want default behaviour to remain the current one :)
So please don't update the descriptor ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if I don't update the descriptor, neither the schema nor the documentation will be updated to reflect that the SPELL_*_FILE_EXTENSIONS parameter can be set, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right :)
To do that, you must remove the condition here :)
https://github.com/bdovaz/megalinter/blob/d03b3efdcb48eefbd813dce5f5628705f6cbc664/.automation/build.py#L1255
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that even removing that second condition won't work because the value of "lint_all_other_linters_files" is set to true: https://github.com/bdovaz/megalinter/blob/main/megalinter/descriptors/spell.megalinter-descriptor.yml
The condition in the script you mentioned compares it to false
Updated |
@nvuillam Can you help me to unlock this PR? Thank you. There is some unresolved conversation I need your guidance on. |
@bdovaz the PR seems fine to me , but i've not validated it yet because it's still in status "draft" :) |
@nvuillam done! |
Thanks a lot for your contribution :) |
Related #1997
@nvuillam questions: