-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSpell doesn't allow to pass SPELL_CSPELL_FILE_EXTENSIONS argument? #1997
Comments
language linters have a specific behaviour: they analyze files that are analysed by other linters |
You mean if I throw these linters:
Is this explained somewhere? It is not easy to understand. Also, what happens if I only want to launch the cspell linter? In that case is it going to be * . *? |
Nope, nothing will be linted ^^ And you're right, it should be explained somewhere.... and maybe we should manage that if FILE_EXTENSIONS is user-defined, it was taken in account except the default behaviour to use other linters files |
I agree. The parameter "SPELL_CSPELL_FILE_EXTENSIONS" (which does not exist now) should serve to override the current behavior that is not documented. If this parameter is defined, it overrides that behavior. |
If you are in a mood for a PR... it will probably happen here :) megalinter/megalinter/utils.py Line 133 in cdaf93b
|
I would try but I don't feel comfortable with python (my world is in .NET) in terms of experience in it nor do I know the guts of megalinter to make this change.... I'll wait for when you can implement it. |
@nvuillam I created a draft PR, can you help/guide me please? Thanks. |
You're close :) |
@nvuillam I see that you have merged it but I don't see that it appears in the beta documentation, shouldn't it show up? https://oxsecurity.github.io/megalinter/beta/descriptors/spell_cspell/ I say this in case there is something missing in some descriptor or some condition of that PR that is not correct. Thanks. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
It's not documented: https://oxsecurity.github.io/megalinter/latest/descriptors/spell_cspell/#readme
And of course it's because it's not in descriptor: https://github.com/oxsecurity/megalinter/blob/79fe208cb54ecb10f90e65b1bb8cc04065273832/megalinter/descriptors/spell.megalinter-descriptor.yml
Is it because of something in particular? Because it seems that it does support it: http://cspell.org/docs/globs/
The text was updated successfully, but these errors were encountered: