Fix Docker container names in pre-commit hooks #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kurt-von-Laven any opinion ? :) |
|
It looks right to me. Just needs a rebase. |
|
@mwarres you know what to do :) |
Codecov Report
@@ Coverage Diff @@
## main #1933 +/- ##
==========================================
+ Coverage 82.03% 82.71% +0.67%
==========================================
Files 157 157
Lines 3384 3384
==========================================
+ Hits 2776 2799 +23
+ Misses 608 585 -23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kurt-von-Laven
requested changes
Oct 6, 2022
The previous Docker container names contained Bash syntax, but pre-commit interprets them as string literals, resulting in invalid Docker container names. Remove Bash syntax, and replace it with string literals.
nvuillam
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1932
The previous Docker container names contained Bash syntax, but pre-commit interprets them as string literals, resulting in invalid Docker container names. Remove Bash syntax, and replace it with string literals.