Skip to content

Commit

Permalink
Fix Docker container names in pre-commit hooks
Browse files Browse the repository at this point in the history
The previous Docker container names contained Bash syntax, but
pre-commit interprets them as string literals, resulting in invalid
Docker container names. Remove Bash syntax, and replace it with string
literals.
  • Loading branch information
mwarres committed Oct 9, 2022
1 parent b11a612 commit 169fceb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .pre-commit-hooks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
require_serial: true
args:
- mega-linter-runner
- --container-name "megalinter-$(basename "$PWD")"
- --containername megalinter-incremental
- --remove-container
- --fix
- --env
Expand Down Expand Up @@ -35,7 +35,7 @@
require_serial: true
args:
- mega-linter-runner
- --container-name "megalinter-all-$(basename "$PWD")"
- --containername megalinter-full
- --remove-container
- --fix
- --env
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-linter.yml file, or with `oxsecurity/megalinter:beta` docker image

- Fix invalid Docker container names in .pre-commit-hooks.yaml ([#1932](https://github.com/oxsecurity/megalinter/issues/1932))
- Correct removeContainer casing in runner ([#1917](https://github.com/oxsecurity/megalinter/issues/1917))
- Use -p argument for pyright custom config file path ([#1946](https://github.com/oxsecurity/megalinter/issues/1946))
- Fix use of TERRAFORM_KICS_ARGUMENTS ([#1947](https://github.com/oxsecurity/megalinter/issues/1947))
Expand Down

0 comments on commit 169fceb

Please sign in to comment.