Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround for legacy katakana middle dot problem #2

Closed
Boshen opened this issue Jun 18, 2024 · 0 comments · Fixed by #3
Closed

workaround for legacy katakana middle dot problem #2

Boshen opened this issue Jun 18, 2024 · 0 comments · Fixed by #3
Assignees
@Boshen

Comments

@Boshen
Copy link
Member

Boshen commented Jun 18, 2024

evanw/esbuild@a05546b

https://github.com/evanw/esbuild/pull/3424
@Boshen Boshen self-assigned this Jun 18, 2024
Boshen added a commit that referenced this issue Jul 8, 2024
@Boshen
patch legacy katakana middle dot
47d2fe4 
closes #2

Unicode 4.1 through Unicode 15 omitted these two characters from ID_Continue
by accident. However, this accident was corrected in Unicode 15.1. Any JS VM
that supports ES6+ but that uses a version of Unicode earlier than 15.1 will
consider these to be a syntax error, so we deliberately omit these characters
from the set of identifiers that are valid in both ES5 and ES6+. For more info
see 2.2 in https://www.unicode.org/L2/L2023/23160-utc176-properties-recs.pdf
@Boshen Boshen mentioned this issue Jul 8, 2024
Merged
Boshen added a commit that referenced this issue Jul 8, 2024
@Boshen
patch legacy katakana middle dot
2191e35 
closes #2

Unicode 4.1 through Unicode 15 omitted these two characters from ID_Continue
by accident. However, this accident was corrected in Unicode 15.1. Any JS VM
that supports ES6+ but that uses a version of Unicode earlier than 15.1 will
consider these to be a syntax error, so we deliberately omit these characters
from the set of identifiers that are valid in both ES5 and ES6+. For more info
see 2.2 in https://www.unicode.org/L2/L2023/23160-utc176-properties-recs.pdf
@Boshen Boshen closed this as completed in #3 Jul 8, 2024
@Boshen Boshen closed this as completed in e66284f Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

patch legacy katakana middle dot oxc-project/unicode-id-start
1 participant
@Boshen