patch legacy katakana middle dot #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #2 Unicode 4.1 through Unicode 15 omitted these two characters from ID_Continue by accident. However, this accident was corrected in Unicode 15.1. Any JS VM that supports ES6+ but that uses a version of Unicode earlier than 15.1 will consider these to be a syntax error, so we deliberately omit these characters from the set of identifiers that are valid in both ES5 and ES6+. For more info see 2.2 in https://www.unicode.org/L2/L2023/23160-utc176-properties-recs.pdf
Boshen
added a commit
to Boshen/swc
that referenced
this pull request
Jul 8, 2024
This unpins the crate version by removing the katana middle dot problem occured in unicode v15.1.0 See oxc-project/unicode-id-start#3 relates swc-project#8940
Boshen
added a commit
to Boshen/swc
that referenced
this pull request
Jul 8, 2024
This unpins the crate version by removing the katana middle dot problem occured in unicode v15.1.0 See oxc-project/unicode-id-start#3 relates swc-project#8940
kdy1
pushed a commit
to swc-project/swc
that referenced
this pull request
Jul 8, 2024
This bumps unicode support to unicode v15.1.0 The crate version is unpinned by removing the katana middle dot problem occured in unicode v15.1.0 See oxc-project/unicode-id-start#3 relates #8940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2
This follows the esbuild PR
https://github.com/evanw/esbuild/pull/3424.Unicode 4.1 through Unicode 15 omitted these two characters from ID_Continue by accident. However, this accident was corrected in Unicode 15.1. Any JS VM that supports ES6+ but that uses a version of Unicode earlier than 15.1 will consider these to be a syntax error, so we deliberately omit these characters from the set of identifiers that are valid in both ES5 and ES6+. For more info see 2.2 in https://www.unicode.org/L2/L2023/23160-utc176-properties-recs.pdf