refactor(transformer): handle `<CWD>` in test runner #7799

Dunqing · 2024-12-11T08:15:07Z

We should move the handling of <CWD> to the test runner because this is just only used in testing, and it causes us always get a path by self.ctx.source_path like <CWD>/xxx/xxx.js, we should get a real path for this.

graphite-app · 2024-12-11T08:15:13Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Dunqing · 2024-12-11T08:15:23Z

refactor(transformer): handle <CWD> in test runner #7799 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2024-12-11T08:22:20Z

CodSpeed Performance Report

Merging #7799 will not alter performance

_{Comparing 12-11-refactor_transformer_handle_cwd_in_test_runner (b290ebd) with main (fb325dc)}

Summary

✅ 29 untouched benchmarks

overlookmotel · 2024-12-11T12:18:08Z

I would be very happy to see this change happen. The path manipulation in TransformCtx::new is one of the largest sources of variance in our transformer benchmarks, so removing it will help a lot with that.

But... just to check, does not stripping options.cwd from start of source path affect the output of JSX Source transform, which uses source_path?

Dunqing · 2024-12-11T14:52:44Z

But... just to check, does not stripping options.cwd from start of source path affect the output of JSX Source transform, which uses source_path?

Yes, it will.

overlookmotel · 2024-12-11T21:37:20Z

Yes, it will.

Is that not a problem?

Dunqing · 2024-12-12T00:43:33Z

Yes, it will.

Is that not a problem?

It is not a problem, we should always get a real path except for testing

overlookmotel · 2024-12-12T12:07:51Z

Agreed we can remove the special case for <CWD>, but doesn't Babel remove cwd from start of the path?

i.e.:

var _jsxFileName = "src/foo/bar.jsx";

not full path:

var _jsxFileName = "/Users/bozo/projects/clownhouse-app/src/foo/bar.jsx";

Dunqing · 2024-12-12T13:41:13Z

Agreed we can remove the special case for <CWD>, but doesn't Babel remove cwd from start of the path?

i.e.:
var _jsxFileName = "src/foo/bar.jsx";
not full path:
var _jsxFileName = "/Users/bozo/projects/clownhouse-app/src/foo/bar.jsx";

No, Babel doesn't remove cwd. Also, the JSX source plugin must need a full path because it provides fileName, lineNumber, and columnNumber so that react devtool chrome extension can according to these details open the original file by VSCode or other editors.

overlookmotel · 2024-12-12T17:21:13Z

OK great. Thanks for bearing with all my questions!

overlookmotel · 2024-12-12T17:21:36Z

Merge activity

Dec 12, 12:21 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 12, 12:21 PM EST: A user added this pull request to the Graphite merge queue.
Dec 12, 12:26 PM EST: A user merged this pull request with the Graphite merge queue.

We should move the handling of `<CWD>` to the test runner because this is just only used in testing, and it causes us always get a path by `self.ctx.source_path` like `<CWD>/xxx/xxx.js`, we should get a real path for this.

## [0.41.0] - 2024-12-13 - fb325dc ast: [**BREAKING**] `span` field must be the first element (#7821) (Boshen) - 96a26d3 ast: [**BREAKING**] Rename `is_strict` methods to `has_use_strict_directive` (#7783) (overlookmotel) ### Features - 8991f33 ast: Add `visit_span` to `Visit` and `VisitMut` (#7816) (overlookmotel) - f7900ab ast: Add `ArrowFunctionExpression::has_use_strict_directive` method (#7784) (overlookmotel) - e727ae9 transformer/class-properties: Transform super member expressions that are inside static prop initializer (#7815) (Dunqing) ### Bug Fixes - 7610dc1 parser: Parse `import source from 'mod'` (#7833) (Boshen) - 9479e2b semantic: Missing references when `export {}` references a type-only binding and a normal (#7812) (Yunfei He) - 7a83230 semantic: Missing reference when `export default` references a type alias binding (#7813) (Dunqing) - 4a3bca8 semantic: Fix identifying strict mode arrow functions (#7785) (overlookmotel) - 5b7e1ad transformer: Remove span of define value (#7811) (Hiroshi Ogawa) - 14896cb transformer/class-properties: Create temp vars in correct scope (#7824) (overlookmotel) - 25bb6da transformer/class-properties: Fix `ScopeId`s in instance prop initializers (#7823) (overlookmotel) - 65b109a transformer/class-properties: No `raw` for generated `StringLiteral` (#7825) (overlookmotel) - 2964a61 transformer/class-properties: Unwrap failed when private field expression doesn't contain optional expression in `ChainExpression` (#7798) (Dunqing) - 6fa6785 transformer/class-properties: Panic when the callee or member is `ParenthesisExpression` or TS-syntax expressions. (#7795) (Dunqing) - bb22c67 transformer/class-properties: Fix `ScopeId`s in static prop initializers (#7791) (overlookmotel) - caa57f1 transformer/class-properties: Fix scope flags in static prop initializers (#7786) (overlookmotel) ### Performance - 4448b63 codegen: Faster writing indentation (#7820) (overlookmotel) - afaaffa codegen: Fast path for `options.print_comments()` (#7806) (Boshen) ### Refactor - 0f367e5 semantic: Improve the logic of resolving references to be cleaner (#7829) (Dunqing) - 5710950 semantic: Move export-related reference flags logic to visit functions (#7828) (Dunqing) - b290ebd transformer: Handle `<CWD>` in test runner (#7799) (Dunqing) - e70deb9 transformer/class-properties: Locate instance props insertion location in separate step (#7819) (overlookmotel) - afc5f1e transformer/class-properties: De-deduplicate code (#7805) (overlookmotel) - 47a91d2 transformer/class-properties: Shorten code (#7804) (overlookmotel) - 54ef2b9 transformer/class-properties: Rename `debug_assert_expr_is_not_parenthesis_or_typescript_syntax` (#7803) (overlookmotel) - 3cdc47c transformer/class-properties: `#[inline(always)]` on `assert_expr_neither_parenthesis_nor_typescript_syntax` (#7802) (overlookmotel) ### Testing - d72c888 transformer/replace-global-defines: Remove panicking test (#7838) (overlookmotel) Co-authored-by: Boshen <[email protected]>

Dunqing marked this pull request as ready for review December 11, 2024 08:15

Dunqing requested a review from overlookmotel as a code owner December 11, 2024 08:15

github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 11, 2024

Dunqing changed the title ~~refactor(transformer): handle <CWD> in test runner~~ refactor(transformer): handle <CWD> in test runner Dec 11, 2024

Dunqing mentioned this pull request Dec 12, 2024

fix(semantic): missing reference when export default references a type alias binding #7813

Merged

overlookmotel approved these changes Dec 12, 2024

View reviewed changes

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 12, 2024

refactor(transformer): handle <CWD> in test runner (#7799)

b290ebd

We should move the handling of `<CWD>` to the test runner because this is just only used in testing, and it causes us always get a path by `self.ctx.source_path` like `<CWD>/xxx/xxx.js`, we should get a real path for this.

overlookmotel force-pushed the 12-11-refactor_transformer_handle_cwd_in_test_runner branch from bb7cf0e to b290ebd Compare December 12, 2024 17:22

graphite-app bot merged commit b290ebd into main Dec 12, 2024
25 checks passed

graphite-app bot deleted the 12-11-refactor_transformer_handle_cwd_in_test_runner branch December 12, 2024 17:26

oxc-bot mentioned this pull request Dec 13, 2024

release(crates): v0.41.0 #7846

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(transformer): handle `<CWD>` in test runner #7799

refactor(transformer): handle `<CWD>` in test runner #7799

Dunqing commented Dec 11, 2024 •

edited

Loading

graphite-app bot commented Dec 11, 2024

Dunqing commented Dec 11, 2024 •

edited

Loading

codspeed-hq bot commented Dec 11, 2024 •

edited

Loading

overlookmotel commented Dec 11, 2024

Dunqing commented Dec 11, 2024

overlookmotel commented Dec 11, 2024

Dunqing commented Dec 12, 2024

overlookmotel commented Dec 12, 2024 •

edited

Loading

Dunqing commented Dec 12, 2024

overlookmotel commented Dec 12, 2024

overlookmotel commented Dec 12, 2024 •

edited by graphite-app bot

Loading

refactor(transformer): handle <CWD> in test runner #7799

refactor(transformer): handle <CWD> in test runner #7799

Conversation

Dunqing commented Dec 11, 2024 • edited Loading

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Dunqing commented Dec 11, 2024 • edited Loading

How to use the Graphite Merge Queue

codspeed-hq bot commented Dec 11, 2024 • edited Loading

CodSpeed Performance Report

Merging #7799 will not alter performance

Summary

overlookmotel commented Dec 11, 2024

Dunqing commented Dec 11, 2024

overlookmotel commented Dec 11, 2024

Dunqing commented Dec 12, 2024

overlookmotel commented Dec 12, 2024 • edited Loading

Dunqing commented Dec 12, 2024

overlookmotel commented Dec 12, 2024

overlookmotel commented Dec 12, 2024 • edited by graphite-app bot Loading

Merge activity

refactor(transformer): handle `<CWD>` in test runner #7799

refactor(transformer): handle `<CWD>` in test runner #7799

Dunqing commented Dec 11, 2024 •

edited

Loading

Dunqing commented Dec 11, 2024 •

edited

Loading

codspeed-hq bot commented Dec 11, 2024 •

edited

Loading

overlookmotel commented Dec 12, 2024 •

edited

Loading

overlookmotel commented Dec 12, 2024 •

edited by graphite-app bot

Loading