refactor(semantic): improve the logic of resolving references to be cleaner #7829
+38
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-semantic
CodSpeed Performance ReportMerging #7829 will not alter performanceComparing Summary
|
Merge activity
|
…leaner (#7829) fine-tuning the logic, reducing unnecessary calls, and early return if it doesn't resolve. Also, add many comments to describe what code does.
Boshen
force-pushed
the
12-13-refactor_semantic_move_export-related_reference_flags_logic_to_visit_functions
branch
from
ee17be6 to
5710950
Compare
Boshen
force-pushed
the
12-13-refactor_semantic_improve_the_logic_of_resolving_references_to_be_cleaner
branch
from
4f98909 to
0f367e5
Compare
Base automatically changed from
12-13-refactor_semantic_move_export-related_reference_flags_logic_to_visit_functions
to
main
December 13, 2024 09:15
graphite-app
bot
deleted the
12-13-refactor_semantic_improve_the_logic_of_resolving_references_to_be_cleaner
branch
Boshen
added a commit
that referenced
this pull request
Dec 13, 2024
## [0.41.0] - 2024-12-13 - fb325dc ast: [**BREAKING**] `span` field must be the first element (#7821) (Boshen) - 96a26d3 ast: [**BREAKING**] Rename `is_strict` methods to `has_use_strict_directive` (#7783) (overlookmotel) ### Features - 8991f33 ast: Add `visit_span` to `Visit` and `VisitMut` (#7816) (overlookmotel) - f7900ab ast: Add `ArrowFunctionExpression::has_use_strict_directive` method (#7784) (overlookmotel) - e727ae9 transformer/class-properties: Transform super member expressions that are inside static prop initializer (#7815) (Dunqing) ### Bug Fixes - 7610dc1 parser: Parse `import source from 'mod'` (#7833) (Boshen) - 9479e2b semantic: Missing references when `export {}` references a type-only binding and a normal (#7812) (Yunfei He) - 7a83230 semantic: Missing reference when `export default` references a type alias binding (#7813) (Dunqing) - 4a3bca8 semantic: Fix identifying strict mode arrow functions (#7785) (overlookmotel) - 5b7e1ad transformer: Remove span of define value (#7811) (Hiroshi Ogawa) - 14896cb transformer/class-properties: Create temp vars in correct scope (#7824) (overlookmotel) - 25bb6da transformer/class-properties: Fix `ScopeId`s in instance prop initializers (#7823) (overlookmotel) - 65b109a transformer/class-properties: No `raw` for generated `StringLiteral` (#7825) (overlookmotel) - 2964a61 transformer/class-properties: Unwrap failed when private field expression doesn't contain optional expression in `ChainExpression` (#7798) (Dunqing) - 6fa6785 transformer/class-properties: Panic when the callee or member is `ParenthesisExpression` or TS-syntax expressions. (#7795) (Dunqing) - bb22c67 transformer/class-properties: Fix `ScopeId`s in static prop initializers (#7791) (overlookmotel) - caa57f1 transformer/class-properties: Fix scope flags in static prop initializers (#7786) (overlookmotel) ### Performance - 4448b63 codegen: Faster writing indentation (#7820) (overlookmotel) - afaaffa codegen: Fast path for `options.print_comments()` (#7806) (Boshen) ### Refactor - 0f367e5 semantic: Improve the logic of resolving references to be cleaner (#7829) (Dunqing) - 5710950 semantic: Move export-related reference flags logic to visit functions (#7828) (Dunqing) - b290ebd transformer: Handle `<CWD>` in test runner (#7799) (Dunqing) - e70deb9 transformer/class-properties: Locate instance props insertion location in separate step (#7819) (overlookmotel) - afc5f1e transformer/class-properties: De-deduplicate code (#7805) (overlookmotel) - 47a91d2 transformer/class-properties: Shorten code (#7804) (overlookmotel) - 54ef2b9 transformer/class-properties: Rename `debug_assert_expr_is_not_parenthesis_or_typescript_syntax` (#7803) (overlookmotel) - 3cdc47c transformer/class-properties: `#[inline(always)]` on `assert_expr_neither_parenthesis_nor_typescript_syntax` (#7802) (overlookmotel) ### Testing - d72c888 transformer/replace-global-defines: Remove panicking test (#7838) (overlookmotel) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fine-tuning the logic, reducing unnecessary calls, and early return if it doesn't resolve. Also, add many comments to describe what code does.