fix: closing editors on search result page #9918
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| @@ -186,6 +187,7 @@ export default defineComponent({ | |||
| driveAliasAndItem | |||
| }, | |||
| query: { | |||
| ...unref(currentRoute).query, | |||
| fileId: id, | |||
| shareId: space.shareId, | |||
| ...(unref(currentRoute).query?.app && { app: unref(currentRoute).query?.app }), | |||
There was a problem hiding this comment.
This here and above becomes unnecessary with your change, I'm wondering if this is really what we want or if this might cause issues somewhere, e.g. with the context route query params...
There was a problem hiding this comment.
Good catch!
I'm wondering if this is really what we want or if this might cause issues somewhere
You mean when re-setting all of the current route's query params? I decided against this initially. But apparently now other things break because params will get lost :/
There was a problem hiding this comment.
Yeah, maybe we can filter out some... iirc we had issues in some bizzare place when we had implemented it like this inititially, maybe login/logout...
There was a problem hiding this comment.
Ah, misreading the diff.. issue happened in closeApp iirc. So if this is feally only overriding a few params but stays on the same page l otherwise, it might be fine.
There was a problem hiding this comment.
It seems so, at least I didn't find any other issues for now.
JammingBen
force-pushed
the
fix-closing-editors-search-result-page
branch
from
da9ae2a to
8700cde
Compare
|
SonarCloud Quality Gate failed.
|
delete-merged-branch
bot
deleted the
fix-closing-editors-search-result-page
branch
…ult-page fix: closing editors on search result page
Description
We noticed this error in the ocis pipeline: https://drone.owncloud.com/owncloud/ocis/28475/40/12. For some reason it didn't fail in Web...
Related Issue
Types of changes