Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolving external URLs via file ID #9891

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: resolving external URLs via file ID #9891

merged 1 commit into from
Oct 31, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Oct 30, 2023 •
edited
Loading

Description

Ports the solution from #9833 to master. This time it's done properly by refactoring some shared logic to the new useGetResourceContext composable.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Oct 30, 2023
@update-docs
Copy link

update-docs bot commented Oct 30, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the fix-external-url-resolving-master branch from 8747e13 to 3ccacf6 Compare October 30, 2023 15:33
@JammingBen JammingBen force-pushed the fix-external-url-resolving-master branch from 3ccacf6 to 86fbb74 Compare October 30, 2023 15:49
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

11.0% 11.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JammingBen JammingBen marked this pull request as ready for review October 30, 2023 16:29
@JammingBen JammingBen mentioned this pull request Oct 30, 2023
Merged
@JammingBen JammingBen merged commit 50e6534 into master Oct 31, 2023
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-external-url-resolving-master branch October 31, 2023 09:25
@JammingBen JammingBen mentioned this pull request Nov 7, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@kulmann kulmann Awaiting requested review from kulmann

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open-with-web endpoint not working
2 participants
@JammingBen @dschmidt